Merge bitcoin/bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #129

DashCoreAutoGuix · 2025-06-18T21:15:41Z

Original commit: 9dce301

Backported from Bitcoin Core v0.25

This small PR adds missing "bech32m" address type / BIP86 checks w.r.t. to the getnewaddress/getrawchangeaddress RPC and descriptor export functionality to the functional test wallet_descriptor.py.

…wallet_descriptor.py 887d85e test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py (Sebastian Falbesoner) Pull request description: This small PR adds missing "bech32m" address type / BIP86 checks w.r.t. to the `getnewaddress`/`getrawchangeaddress` RPC and descriptor export functionality to the functional test `wallet_descriptor.py`. ACKs for top commit: shaavan: ACK 887d85e kristapsk: ACK 887d85e Tree-SHA512: 05b443ae14138769dc3c87a0178f21db2698fa5bcbeaa953c50ed0c9cf5dcd1effcf4afd09551ca9f4ce73898a7882caaf4c57078767beb6a6a65eb3a662726d

coderabbitai · 2025-06-18T21:15:47Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Remove p2sh-segwit and bech32 test additions that were not in the original Bitcoin commit. Only add bech32m test cases as per bitcoin#26472. Original Bitcoin commit 887d85e only added bech32m support, but this PR was adding comprehensive address type coverage including p2sh-segwit and bech32 which should be separate backports. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

DashCoreAutoGuix · 2025-06-19T05:03:58Z

✅ Backport Verification - Issues Fixed

I found scope creep in this backport and automatically applied fixes.

Original Bitcoin commit: 887d85e43d136dbfc2428f873ced3de50076bbd0
Changes pushed to branch: backport-0.25-batch-244-pr-26472
Fix commit: ee3af07d84

Issues Found and Fixed:

🔍 Scope Creep Detected

Bitcoin commit added: Only bech32m address type testing (13 additions, 1 deletion)
Original Dash PR added: p2sh-segwit, bech32, AND bech32m testing (35 additions, 1 deletion)
Size ratio: 257% of Bitcoin's changes (far exceeding 80-150% validation threshold)

🛠️ Fixes Applied:

Removed scope creep: Eliminated p2sh-segwit and bech32 test additions
Preserved Bitcoin's intent: Kept only bech32m test cases as per original commit
Updated test arrays: Removed extra entries from addr_types array

📊 Results After Fix:

Current size: 11 additions, 1 deletion (12 total changes)
Bitcoin size: 13 additions, 1 deletion (14 total changes)
Size ratio: ~86% (within acceptable 80-150% range)

Root Cause Analysis:

The scope creep occurred because Dash's test file was missing previous Bitcoin backports that had added p2sh-segwit and bech32 test coverage. This PR attempted to add all missing coverage at once, rather than faithfully backporting only the bech32m additions from bitcoin#26472.

Backporting Principle Applied:

"Preserve Bitcoin's intent with minimal Dash adaptations"

Each backport should only add what that specific Bitcoin commit added
Missing prior backports should be handled as separate PRs
Scope creep dilutes the faithfulness of individual backports

The backport should now be complete and faithful to the original Bitcoin change. ✅

DashCoreAutoGuix · 2025-07-25T05:31:38Z

❌ Backport Verification - CATASTROPHIC FAILURE

Original Bitcoin commit: `9dce30194b` (Merge bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py)
Reviewed commit hash: `ee3af07d84-verify-${TIMESTAMP}`

CRITICAL VIOLATIONS DETECTED:

🚨 Architectural Incompatibility Violation

What Bitcoin Did: Added bech32m (Taproot) test cases ONLY - 4 test additions for BIP86/Taproot functionality
What This PR Attempts: Import Taproot test cases to Dash (which doesn't support Taproot)
Problem: Dash does not implement Taproot/bech32m addresses - this is a Bitcoin-specific consensus feature

🚨 CI Status: CRITICAL

2 test failures in wallet_descriptor.py
Tests fail because `getnewaddress("", "bech32m")` RPC call doesn't exist in Dash
Direct result of trying to test unsupported blockchain features

🚨 Intent Violation

Bitcoin's Intent: Test bech32m address generation and BIP86 key derivation paths
Fundamental Problem: Dash uses different address types and doesn't support Taproot
Result: Impossible to faithfully backport - this is not an adaptation issue but architectural incompatibility

🚨 Reviewer Feedback Analysis

PastaPastaPasta comments reviewed: 0
Other human comments reviewed: 0
No comments because this PR was auto-generated without human review of compatibility

Required Action: COMPLETE REJECTION

This backport attempts to import Bitcoin consensus features that don't exist in Dash:

bech32m addresses: Taproot address format (Bitcoin-only)
BIP86 key derivation: Taproot-specific key paths (m/86'/1'/0')
`tr()` descriptors: Taproot descriptor format (Bitcoin-only)

Correct Action:

SKIP this Bitcoin commit entirely - it only applies to Taproot-enabled chains
Document as "Not applicable to Dash - requires Taproot consensus features"
Do not attempt any adaptation - the entire commit is Bitcoin-specific

Status: REJECTED - Bitcoin Taproot feature incompatible with Dash

🚫 This PR has been automatically closed due to architectural incompatibility. Bitcoin commit 9dce301 adds Taproot-specific functionality that cannot be backported to Dash.

DashCoreAutoGuix · 2025-07-25T05:31:45Z

Automatically closed due to architectural incompatibility. Bitcoin commit 9dce301 adds Taproot-specific test functionality that cannot be backported to Dash, which does not support Taproot consensus features.

DashCoreAutoGuix closed this Jul 25, 2025

DashCoreAutoGuix added the invalid This doesn't seem right label Jul 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge bitcoin/bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #129

Merge bitcoin/bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #129

Uh oh!

DashCoreAutoGuix commented Jun 18, 2025

Uh oh!

coderabbitai bot commented Jun 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

DashCoreAutoGuix commented Jun 19, 2025

Uh oh!

DashCoreAutoGuix commented Jul 25, 2025

Uh oh!

DashCoreAutoGuix commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Merge bitcoin/bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #129

Merge bitcoin/bitcoin#26472: test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #129

Uh oh!

Conversation

DashCoreAutoGuix commented Jun 18, 2025

Uh oh!

coderabbitai bot commented Jun 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

DashCoreAutoGuix commented Jun 19, 2025

✅ Backport Verification - Issues Fixed

Issues Found and Fixed:

🔍 Scope Creep Detected

🛠️ Fixes Applied:

📊 Results After Fix:

Root Cause Analysis:

Backporting Principle Applied:

Uh oh!

DashCoreAutoGuix commented Jul 25, 2025

❌ Backport Verification - CATASTROPHIC FAILURE

🚨 Architectural Incompatibility Violation

🚨 CI Status: CRITICAL

🚨 Intent Violation

🚨 Reviewer Feedback Analysis

Required Action: COMPLETE REJECTION

Uh oh!

DashCoreAutoGuix commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)