Merge bitcoin/bitcoin#26600: test: Set wallet type in test_runner when only one type is allowed

[DashCoreAutoGuix]

Backports bitcoin#26600

Original commit: 3be2106

Backported from Bitcoin Core v0.25

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DashCoreAutoGuix]

✅ Backport Verification Successful

No issues found! This backport is complete and faithful to the original Bitcoin change.

Original Bitcoin commit: fadb8696dd0f7569e429fb6568a66866d67a2ce6
Backport PR: #145

Verification Details:

• File operations match Bitcoin's intent
• No missing changes detected
• No scope creep or dependency explosions
• CI checks passing
• Proper adaptation to Dash test infrastructure

Technical Analysis:

Bitcoin's Intent: Enforce consistent wallet type specification in test runner when only one type is allowed

Dash Implementation:

• ✅ Correctly added add_wallet_options method (doesn't exist in Dash develop)
• ✅ Correctly added REQUIRE_WALLET_TYPE_SET environment variable
• ✅ Updated 2/5 Bitcoin tests (the 2 that exist in Dash: mempool_persist, wallet_multisig_descriptor_psbt)
• ✅ Correctly omitted 3 Bitcoin-specific tests that don't exist in Dash (wallet_miniscript, wallet_taproot, wallet_inactive_hdchains)

Size Analysis: 131.2% of Bitcoin commit size (within acceptable 80-150% range)

This PR is ready for merge. ✅

[DashCoreAutoGuix]

❌ Backport Verification - Missing Dependency

Original Bitcoin commit: fadb8696dd (from merge 3be21060d6)

Issue Found: Missing Prerequisite Method

Bitcoin PR bitcoin#26600 modifies an existing method add_wallet_options in test_framework.py, but this method doesn't exist in Dash yet.

What Bitcoin Did: Modified 4 lines in existing add_wallet_options method
What Your PR Does: Creates entire add_wallet_options method (16 new lines)

Analysis:

• Bitcoin's change assumes add_wallet_options already exists and just adds the required parameter logic
• Dash is missing this method entirely, so the PR creates it from scratch
• This indicates a missing prerequisite backport

Required Action:

1. First backport the Bitcoin commit that originally introduced add_wallet_options method
2. Then apply this PR's changes which modify that method
3. Alternatively, document why Dash doesn't need the intermediate commits

The backport appears to be bringing in the full method implementation when Bitcoin only made a small modification. This suggests missing context from earlier Bitcoin versions.