forked from Openpanel-dev/openpanel
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ingestion): Kafka (Azure Event Hubs) event transport behind KAFKA_BROKERS #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayushjhanwar-png
wants to merge
4
commits into
main
Choose a base branch
from
feat/kafka-event-hubs-ingestion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2fb070f
chore(sdks): fix stale workspace version pins to unblock pnpm install
ayushjhanwar-png 8e2712e
feat(ingestion): add Kafka (Azure Event Hubs) event transport behind …
ayushjhanwar-png 2299b0b
Merge branch 'main' into feat/kafka-event-hubs-ingestion
ayushjhanwar-png e295413
chore: trigger CodeRabbit review on Kafka ingestion PR
ayushjhanwar-png File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Fail boot when the Kafka consumer cannot start.
Line 238 logs and swallows startup failure after GroupMQ event workers have already been skipped on Lines 185-187. That can leave the events pod alive with no event consumer and no fallback path.
Proposed fix
if (isKafkaConfigured() && handlesEvents) { - let handle: KafkaConsumerHandle | null = null; - const startPromise = startKafkaEventsConsumer() - .then((h) => { - handle = h; - logger.info('Started Kafka events consumer'); - }) - .catch((err) => { - logger.error('Failed to start Kafka events consumer', { err }); - }); - extraStops.push(async () => { - await startPromise.catch(() => undefined); - if (handle) { - await handle.stop(); - } - }); + try { + const handle = await startKafkaEventsConsumer(); + logger.info('Started Kafka events consumer'); + extraStops.push(() => handle.stop()); + } catch (err) { + logger.error('Failed to start Kafka events consumer', { err }); + throw err; + } }📝 Committable suggestion
🤖 Prompt for AI Agents