Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Association #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Association #131
Changes from all commits
2743f04
79b8cc6
35f0677
89b66d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join predicates reference may not match renamed columns.
The join predicates reference columns like
merged_df["item_1"]
andproduct_occurrences_1["item_1"]
, but given the rename issues above, these columns might not exist as expected.This will need to be fixed after addressing the rename operations in lines 241-246. The join predicates should reference the correctly named columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency in join predicates with renamed tables.
The join operations use predicates that reference columns like
cooccurrences["item_1"]
andproduct_occurrences_1_rename["item_1"]
, but given the rename issues above, these columns might not match as expected.This will need to be fixed after addressing the rename operations in lines 266-271.
This comment was marked as resolved.
Sorry, something went wrong.