Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Segmentation #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Segmentation #154
Changes from all commits
6a4058b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file exist? I don't see it in the PR
Check warning on line 32 in pyretailscience/segmentation/base.py
pyretailscience/segmentation/base.py#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Initialization method has thorough validation.
The
__init__
method includes comprehensive validation of input parameters and handles different input types appropriately.However, there's a potential Python version compatibility issue:
🏁 Script executed:
Length of output: 317
Attention: Python Version Compatibility for
datetime.UTC
datetime.UTC
inpyretailscience/segmentation/rfm.py
(line 58) may lead to compatibility issues on Python versions earlier than 3.11.pyproject.toml
) does not enforce a minimum Python version, so consider either:datetime.UTC
with the more broadly supporteddatetime.timezone.utc
for compatibility with older Python versions.