Skip to content

AJ-1026: actually upgrade snakeyaml #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023
Merged

AJ-1026: actually upgrade snakeyaml #229

merged 1 commit into from
May 8, 2023

Conversation

davidangb
Copy link
Collaborator

@davidangb davidangb commented May 6, 2023

In #226 I tried to upgrade snakeyaml, but was ineffective. I specified a dependency constraint … but since the versions controlled by io.spring.dependency-management take precedence, the constraint did nothing.

This comment helps with confidence that Spring Boot 2.7.11 and snakeyaml 2.0 work ok together.

In this PR:

  • upgrade snakeyaml via the dependencyManagement block, which is the io.spring.dependency-management-specific way to do it
  • remove the ugly rewrite-pom hack which is no longer necessary.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@davidangb davidangb merged commit c3b2c58 into main May 8, 2023
@davidangb davidangb deleted the da_snakeyamlAgain branch May 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants