Make Pip willing to hide system Python modules #5321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides system Python modules when Toil needs a newer version. This should fix #5320.
This should mostly be fine except when the Toil docker uses the system standard Python version, when it is not fine at all and might break system components like
software-properties-common
.The real solution is to migrate from system Toil and
--system-site-packages
for user venvs, to a main Toil venv and.pth
files to connect it to user venvs, but that requires Toil changes to understand which venvs it should hot-deploy and which it shouldn't.Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist