-
Notifications
You must be signed in to change notification settings - Fork 156
[RUM Profiler] Use clocks for start/end time #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 92.20% 92.20% -0.01%
==========================================
Files 312 312
Lines 8031 8030 -1
Branches 1814 1814
==========================================
- Hits 7405 7404 -1
Misses 626 626 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
start: start.toISOString(), | ||
end: end.toISOString(), | ||
start: new Date(profilerStartClocks.timeStamp).toISOString(), | ||
end: new Date(profilerEndClocks.timeStamp).toISOString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 nitpick: we could extract specific type / helper for this format
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
View all feedbacks in Devflow UI.
Commit c0f9f9d524 will soon be integrated into staging-18.
Commit c0f9f9d524 has been merged into staging-18 in merge commit f1df86652b. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: c0f9f9d Co-authored-by: thomasbertet <[email protected]>
@BenoitZugmeyer Thank you for the review! |
Motivation
We are not using the exact same clocks when collecting long tasks (& LoAF) in both the Browser SDK and the RUM Profiler.
Let's have the RUM Profiler use the same clocks.
Changes
RelativeTime
types.Test instructions
Checklist