Skip to content

Print traceback in case of InfraError in Static Quality Gates #39048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

JSGette
Copy link
Contributor

@JSGette JSGette commented Jul 18, 2025

What does this PR do?

It simply adds traceback.print_exception(e) in case of InfraError to ensure
that we see the original error message and where it occurred.

Motivation

Sometimes static quality gates are failing, but we are unable to see
the root cause as original InfraError exception is suppressed and
the error message is replaced with something generic. This PR
improves visibility of errors that should enable developers in
debugging.

Describe how you validated your changes

New unit test is added to ensure we see the original InfraError message.

Possible Drawbacks / Trade-offs

None

Additional Notes

@JSGette JSGette self-assigned this Jul 18, 2025
@JSGette JSGette added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 18, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jul 18, 2025
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 726016ed-615a-40a7-8188-b8d7db20a97d

Baseline: 5ba5f15
Comparison: 7d15bbb
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.71 [-2.35, +3.77] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.80 [+0.94, +2.66] 1 Logs
docker_containers_cpu % cpu utilization +0.71 [-2.35, +3.77] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.60 [+0.54, +0.65] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.60, +0.67] 1 Logs
ddot_metrics memory utilization +0.02 [-0.10, +0.14] 1 Logs
ddot_logs memory utilization +0.01 [-0.08, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.63, +0.60] 1 Logs
file_tree memory utilization -0.01 [-0.05, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.28, +0.24] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.68, +0.57] 1 Logs
quality_gate_idle_all_features memory utilization -0.23 [-0.29, -0.16] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.23 [-0.29, -0.18] 1 Logs
otlp_ingest_metrics memory utilization -0.25 [-0.39, -0.10] 1 Logs
docker_containers_memory memory utilization -0.27 [-0.31, -0.23] 1 Logs
otlp_ingest_logs memory utilization -0.52 [-0.64, -0.39] 1 Logs
quality_gate_idle memory utilization -0.60 [-0.63, -0.57] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.36 [-4.09, +1.37] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 18, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5ba5f15

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${703.1}$$ < $${703.45}$$ $${+0.04}$$ $${177.58}$$ < $${178.35}$$
agent_deb_amd64_fips $${-0}$$ $${701.35}$$ < $${701.7}$$ $${+0.01}$$ $${176.97}$$ < $${177.76}$$
agent_heroku_amd64 $${0}$$ $${354.46}$$ < $${355.37}$$ $${-0}$$ $${94.81}$$ < $${95.72}$$
agent_msi $${0}$$ $${977.33}$$ < $${978.18}$$ $${+0}$$ $${148.51}$$ < $${149.26}$$
agent_rpm_amd64 $${-0}$$ $${703.09}$$ < $${703.44}$$ $${-0.02}$$ $${179.09}$$ < $${179.87}$$
agent_rpm_amd64_fips $${-0}$$ $${701.34}$$ < $${701.69}$$ $${+0.02}$$ $${178.78}$$ < $${179.47}$$
agent_rpm_arm64 $${-0}$$ $${693.05}$$ < $${693.48}$$ $${+0.06}$$ $${162.9}$$ < $${163.62}$$
agent_rpm_arm64_fips $${-0}$$ $${691.35}$$ < $${691.79}$$ $${-0}$$ $${161.86}$$ < $${162.65}$$
agent_suse_amd64 $${-0}$$ $${703.09}$$ < $${703.44}$$ $${-0.02}$$ $${179.09}$$ < $${179.87}$$
agent_suse_amd64_fips $${-0}$$ $${701.34}$$ < $${701.69}$$ $${+0.02}$$ $${178.78}$$ < $${179.47}$$
agent_suse_arm64 $${-0}$$ $${693.05}$$ < $${693.48}$$ $${+0.06}$$ $${162.9}$$ < $${163.62}$$
agent_suse_arm64_fips $${-0}$$ $${691.35}$$ < $${691.79}$$ $${-0}$$ $${161.86}$$ < $${162.65}$$
docker_agent_amd64 $${-0}$$ $${786.85}$$ < $${787.26}$$ $${-0.01}$$ $${270.78}$$ < $${271.51}$$
docker_agent_arm64 $${-0}$$ $${800.32}$$ < $${800.74}$$ $${-0}$$ $${258.45}$$ < $${259.24}$$
docker_agent_jmx_amd64 $${-0}$$ $${978.09}$$ < $${978.45}$$ $${+0}$$ $${339.79}$$ < $${340.47}$$
docker_agent_jmx_arm64 $${-0}$$ $${980.16}$$ < $${980.54}$$ $${+0.01}$$ $${323.45}$$ < $${324.2}$$
docker_cluster_agent_amd64 $${-0}$$ $${213.75}$$ < $${214.5}$$ $${-0}$$ $${72.66}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${-0}$$ $${229.62}$$ < $${230.33}$$ $${+0}$$ $${68.93}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${39.2}$$ < $${39.57}$$ $${-0}$$ $${15.11}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.86}$$ < $${38.2}$$ $${0}$$ $${14.53}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.43}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${29.0}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.43}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${30.43}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${53.92}$$ < $${54.55}$$ $${-0}$$ $${13.59}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.25}$$ < $${51.9}$$ $${-0}$$ $${11.75}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${50.76}$$ < $${51.42}$$ $${+0.01}$$ $${11.83}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${53.92}$$ < $${54.55}$$ $${-0}$$ $${13.61}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.25}$$ < $${51.91}$$ $${-0}$$ $${11.77}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${53.92}$$ < $${54.55}$$ $${-0}$$ $${13.61}$$ < $${14.47}$$

@JSGette JSGette marked this pull request as ready for review July 18, 2025 11:26
@JSGette JSGette requested review from a team as code owners July 18, 2025 11:26
Copy link
Contributor

@rdesgroppes rdesgroppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jul 18, 2025
@JSGette JSGette force-pushed the jsgette/fix_suppressed_infraerror_messages branch from 7d15bbb to 5a0e18c Compare July 18, 2025 11:45
Copy link
Contributor

@alopezz alopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JSGette
Copy link
Contributor Author

JSGette commented Jul 21, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 21, 2025

View all feedbacks in Devflow UI.

2025-07-21 09:17:12 UTC ℹ️ Start processing command /merge


2025-07-21 09:17:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).


2025-07-21 10:00:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 26dd53c into main Jul 21, 2025
237 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jsgette/fix_suppressed_infraerror_messages branch July 21, 2025 10:00
@github-actions github-actions bot added this to the 7.70.0 milestone Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants