Skip to content

RUM-9525 Generate Model Initializers #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 2 commits into from
Apr 28, 2025
Merged

RUM-9525 Generate Model Initializers #2270

dd-mergequeue merged 2 commits into from
Apr 28, 2025

Conversation

@maxep
Copy link
Member

@maxep maxep commented Apr 24, 2025

What and why?

In the effort of moving model definitions to shared module, we need to generate public initialisers for RUM schema.

How?

Modify RUM model generator to create initialisers to all structs.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@maxep maxep requested review from a team as code owners April 24, 2025 08:24
@maxep maxep force-pushed the maxep/RUM-9525/generate-model-initialisers branch 4 times, most recently from 60ae6b3 to d526a43 Compare April 24, 2025 10:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 24, 2025 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-9525/generate-model-initialisers
Commit report: feb774e
Test service: dd-sdk-ios

✅ 0 Failed, 745 Passed, 3159 Skipped, 2m 13.52s Total duration (2m 1.29s time saved)

@maxep maxep force-pushed the maxep/RUM-9525/generate-model-initialisers branch from d526a43 to feb774e Compare April 24, 2025 11:33
simaoseica-dd
simaoseica-dd approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxep
Copy link
Member Author

maxep commented Apr 28, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-28 10:09:45 UTC ℹ️ Start processing command /merge

2025-04-28 10:09:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 36m (p90).

2025-04-28 10:46:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a33e8aa into develop Apr 28, 2025
16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxep/RUM-9525/generate-model-initialisers branch April 28, 2025 10:46
@maxep maxep mentioned this pull request May 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxep @simaoseica-dd