Add gofmt & go mod tidy in CI

[vinckama]

Add gofmt and go mod tidy in the CI to make sure go files are always formatted. Before fixing formatting, the CI failed, it demonstrates that the formatter works as expected:

[fbryden]

I'm not exactly sure how this works in a CI...but -w will "fix" the code. Is -d the more "suitable" option here, which displays the issues rather than fixes them?

[vinckama]

I think the challenge here is that the failed command is github do not make the test to fail. See this discussion, I think it is still not implemented yet

[vinckama]

I tried on 1e49fd0, to double check the behavior, moving the PR to draft again

edit: after testing gofmt -s -d ., the CI does not fail in that case:

[fbryden]

ah I was going to suggest something I thought was smart - but I just found it in the thread you linked lol

[fbryden]

I'm currently testing this in my own PR:

  script:
    # Only the sds-go folder needs to be checked since generation-checks takes care of the generated code
    - output=$(gofmt -d -s sds-go)
    - if [[ -n "$output" ]]; then echo "gofmt failed"; echo "$output"; exit 1; fi

[fbryden]

https://gitlab.ddbuild.io/DataDog/sds-shared-library/-/jobs/705361200
This works

[vinckama]

The script suggested is more complicated than the current one. I'm not sure it's a real improvement

[fbryden]

Sorry I'd missed your suggestion - I agree with you and I'll be following that in my own PR.

[vinckama]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-13 16:11:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-11-13 16:11:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-11-13 16:19:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 0s.

---

2024-11-13 17:42:34 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

[fbryden]

LGTM