Skip to content

chore(aws_lambda): bump minimum supported version #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 30, 2025

aws_lambda<6.105.0 requires imports that were removed in ddtrace v3.0. This PR documents a new minimum supported version for aws_lambda and updates tests.

Blocked by: DataDog/datadog-lambda-python#557

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 30, 2025

CODEOWNERS have been resolved as:

.riot/requirements/1460efe.txt                                          @DataDog/apm-python
.riot/requirements/1965d6b.txt                                          @DataDog/apm-python
.riot/requirements/1aec773.txt                                          @DataDog/apm-python
.riot/requirements/1ecfbd7.txt                                          @DataDog/apm-python
.riot/requirements/6824c99.txt                                          @DataDog/apm-python
.riot/requirements/7cf5b29.txt                                          @DataDog/apm-python
.riot/requirements/b0f80c7.txt                                          @DataDog/apm-python
.riot/requirements/bc071f4.txt                                          @DataDog/apm-python
.riot/requirements/ce0b0e6.txt                                          @DataDog/apm-python
.riot/requirements/d3868d9.txt                                          @DataDog/apm-python
releasenotes/notes/upgrade-min-aws-lambda-f9d9d31cf1f8685f.yaml         @DataDog/apm-python
.riot/requirements/16af7e0.txt                                          @DataDog/apm-python
.riot/requirements/1fa807e.txt                                          @DataDog/apm-python
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025

Datadog Report

Branch report: munir/upgrade-min-aws-lambda
Commit report: 37948e9
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 55.35s Total duration (35m 43.07s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-01-31 17:15:54

Comparing candidate commit 37948e9 in PR branch munir/upgrade-min-aws-lambda with baseline commit 4ebedf0 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/upgrade-min-aws-lambda branch from 39fb0de to 50ad4a4 Compare January 30, 2025 22:21
@mabdinur mabdinur marked this pull request as ready for review January 30, 2025 22:22
@mabdinur mabdinur requested review from a team as code owners January 30, 2025 22:22
@mabdinur mabdinur changed the title chore(aws_lambda): bump minimum supported version ci(aws_lambda): bump minimum supported version Jan 30, 2025
@mabdinur mabdinur changed the title ci(aws_lambda): bump minimum supported version chore(aws_lambda): bump minimum supported version Jan 30, 2025
@mabdinur mabdinur enabled auto-merge (squash) January 31, 2025 01:39
@mabdinur mabdinur requested a review from duncanista January 31, 2025 02:28
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 31, 2025
@mabdinur mabdinur requested review from a team as code owners January 31, 2025 15:02
@mabdinur mabdinur requested a review from ZStriker19 January 31, 2025 15:02
@mabdinur mabdinur force-pushed the munir/upgrade-min-aws-lambda branch from ff14361 to 8d2d4e8 Compare January 31, 2025 15:10
@mabdinur mabdinur removed the changelog/no-changelog A changelog entry is not required for this PR. label Jan 31, 2025
@mabdinur mabdinur merged commit 1779b19 into 3.x-staging Jan 31, 2025
684 checks passed
@mabdinur mabdinur deleted the munir/upgrade-min-aws-lambda branch January 31, 2025 17:17
gnufede pushed a commit that referenced this pull request Feb 19, 2025
`aws_lambda<6.105.0` requires imports that were removed in ddtrace v3.0.
This PR documents a new minimum supported version for aws_lambda and
updates tests.

Blocked by: DataDog/datadog-lambda-python#557

## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants