Skip to content

dac strip io from vertex #13693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

jsimpher
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@jsimpher jsimpher changed the title Jsimpher/dac strip io from vertex dac strip io from vertex Jun 17, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/vertexai/_utils.py                             @DataDog/ml-observability
ddtrace/contrib/internal/vertexai/patch.py                              @DataDog/ml-observability
ddtrace/llmobs/_integrations/utils.py                                   @DataDog/ml-observability
ddtrace/llmobs/_integrations/vertexai.py                                @DataDog/ml-observability

Copy link
Contributor

github-actions bot commented Jun 17, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 4 ms.

The average import time from base is: 275 ± 3 ms.

The import time difference between this PR and base is: 3.3 ± 0.2 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 1.312 ms (0.47%)
ddtrace.bootstrap.sitecustomize 0.806 ms (0.29%)
ddtrace.bootstrap.preload 0.412 ms (0.15%)
ddtrace.internal.products 0.117 ms (0.04%)
importlib.metadata 0.117 ms (0.04%)
zipfile 0.117 ms (0.04%)
zipfile._path 0.117 ms (0.04%)
multiprocessing.sharedctypes 0.114 ms (0.04%)
multiprocessing.heap 0.114 ms (0.04%)
mmap 0.114 ms (0.04%)
ddtrace.settings.crashtracker 0.050 ms (0.02%)
ddtrace.internal.datadog.profiling.crashtracker 0.050 ms (0.02%)
ddtrace.internal.datadog.profiling.crashtracker._crashtracker 0.050 ms (0.02%)
ddtrace.internal.flare.flare 0.037 ms (0.01%)
logging.handlers 0.037 ms (0.01%)
multiprocessing 0.034 ms (0.01%)
multiprocessing.context 0.034 ms (0.01%)
multiprocessing.reduction 0.034 ms (0.01%)
pickle 0.034 ms (0.01%)
ddtrace.settings.profiling 0.034 ms (0.01%)
ddtrace.internal.datadog.profiling.ddup 0.034 ms (0.01%)
ddtrace.internal.datadog.profiling.ddup._ddup 0.034 ms (0.01%)
ddtrace.internal.remoteconfig._connectors 0.024 ms (0.01%)
ddtrace.appsec._common_module_patches 0.206 ms (0.07%)
ddtrace.appsec._asm_request_context 0.206 ms (0.07%)
ddtrace.appsec._utils 0.206 ms (0.07%)
ddtrace._trace.trace_handlers 0.189 ms (0.07%)
ddtrace._trace._inferred_proxy 0.120 ms (0.04%)
ddtrace.propagation.http 0.120 ms (0.04%)
ddtrace.internal._tagset 0.037 ms (0.01%)
ddtrace 0.506 ms (0.18%)
ddtrace._logger 0.281 ms (0.10%)
ddtrace.internal.telemetry 0.281 ms (0.10%)
ddtrace.internal.telemetry.writer 0.198 ms (0.07%)
http.client 0.198 ms (0.07%)
email.parser 0.116 ms (0.04%)
email.feedparser 0.116 ms (0.04%)
email._policybase 0.116 ms (0.04%)
email.header 0.116 ms (0.04%)
email.charset 0.116 ms (0.04%)
ssl 0.081 ms (0.03%)
_ssl 0.081 ms (0.03%)
ddtrace.settings._agent 0.083 ms (0.03%)
socket 0.083 ms (0.03%)
_socket 0.035 ms (0.01%)
ddtrace.settings._config 0.134 ms (0.05%)
ddtrace.internal.gitmetadata 0.134 ms (0.05%)
ddtrace.ext.ci 0.134 ms (0.05%)
ddtrace.ext.git 0.134 ms (0.05%)
tempfile 0.134 ms (0.05%)
ddtrace.trace 0.091 ms (0.03%)
ddtrace._trace.filters 0.037 ms (0.01%)
ddtrace._trace.processor 0.037 ms (0.01%)
ddtrace.internal.dogstatsd 0.037 ms (0.01%)
ddtrace.vendor.dogstatsd 0.037 ms (0.01%)
ddtrace.vendor.dogstatsd.base 0.037 ms (0.01%)

The following import paths have shrunk:

ddtrace.auto 1.205 ms (0.43%)
ddtrace 0.667 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)
ddtrace.bootstrap.sitecustomize 0.538 ms (0.19%)
ddtrace.bootstrap.preload 0.538 ms (0.19%)
ddtrace.internal.remoteconfig.client 0.538 ms (0.19%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2025

Benchmarks

Benchmark execution time: 2025-06-17 17:43:08

Comparing candidate commit 89fad2c in PR branch jsimpher/dac-strip-io-from-vertex with baseline commit bd7f202 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 561 metrics, 3 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant