-
Notifications
You must be signed in to change notification settings - Fork 475
fix(django): allow UUID format user ids #15741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Performance SLOsComparing candidate fix-uuid-django-span-attribute-check (bc550f7) with baseline main (6ea41ee) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.102µs (SLO: <20.000µs -9.5%) vs baseline: 📈 +21.3% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 14.948µs (SLO: <20.000µs 📉 -25.3%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -1.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 18.100µs (SLO: <30.000µs 📉 -39.7%) vs baseline: +1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 24.171µs (SLO: <30.000µs 📉 -19.4%) vs baseline: +1.3% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 2.752µs (SLO: <10.000µs 📉 -72.5%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.471µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 16.781µs (SLO: <20.000µs 📉 -16.1%) vs baseline: +1.0% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 1.422µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 56.080µs (SLO: <70.000µs 📉 -19.9%) vs baseline: +0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 3.271µs (SLO: <10.000µs 📉 -67.3%) vs baseline: -0.9% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 14.744µs (SLO: <20.000µs 📉 -26.3%) vs baseline: +1.0% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 2.593µs (SLO: <10.000µs 📉 -74.1%) vs baseline: -1.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.715µs (SLO: <20.000µs 📉 -26.4%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 3.171µs (SLO: <10.000µs 📉 -68.3%) vs baseline: ~same Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ decode_aspectTime: ✅ 15.670µs (SLO: <30.000µs 📉 -47.8%) vs baseline: -0.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -1.7% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 18.272µs (SLO: <30.000µs 📉 -39.1%) vs baseline: 📈 +23.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.507µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +0.9% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 171.098µs (SLO: <200.000µs 📉 -14.5%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 190.711µs (SLO: <200.000µs -4.6%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 3.796µs (SLO: <10.000µs 📉 -62.0%) vs baseline: +0.7% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 3.154µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.434µs (SLO: <20.000µs 📉 -22.8%) vs baseline: +1.1% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 17.102µs (SLO: <20.000µs 📉 -14.5%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 1.560µs (SLO: <10.000µs 📉 -84.4%) vs baseline: -0.7% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 20.933µs (SLO: <30.000µs 📉 -30.2%) vs baseline: +0.6% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 2.719µs (SLO: <10.000µs 📉 -72.8%) vs baseline: +0.5% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.893µs (SLO: <30.000µs 📉 -40.4%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 2.427µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 17.758µs (SLO: <30.000µs 📉 -40.8%) vs baseline: +0.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 1.839µs (SLO: <10.000µs 📉 -81.6%) vs baseline: -1.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 166.261µs (SLO: <200.000µs 📉 -16.9%) vs baseline: -0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.582µs (SLO: <200.000µs 📉 -12.7%) vs baseline: +0.2% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 168.534µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.700µs (SLO: <200.000µs 📉 -14.1%) vs baseline: -0.4% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 3.681µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 212.697µs (SLO: <300.000µs 📉 -29.1%) vs baseline: +0.4% Memory: ✅ 42.684MB (SLO: <44.000MB -3.0%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 3.008µs (SLO: <10.000µs 📉 -69.9%) vs baseline: +2.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.527µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 23.056µs (SLO: <30.000µs 📉 -23.1%) vs baseline: 📈 +21.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 1.927µs (SLO: <10.000µs 📉 -80.7%) vs baseline: -1.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 15.931µs (SLO: <20.000µs 📉 -20.3%) vs baseline: +0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 54.393µs (SLO: <80.000µs 📉 -32.0%) vs baseline: +1.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 3.637µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -0.8% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 17.690µs (SLO: <20.000µs 📉 -11.5%) vs baseline: +0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 1.865µs (SLO: <10.000µs 📉 -81.3%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 18.522µs (SLO: <30.000µs 📉 -38.3%) vs baseline: +0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.798µs (SLO: <10.000µs 📉 -72.0%) vs baseline: +0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 18.235µs (SLO: <30.000µs 📉 -39.2%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 2.675µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +0.1% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 20.632µs (SLO: <30.000µs 📉 -31.2%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.332µs (SLO: <10.000µs 📉 -56.7%) vs baseline: -1.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 17.868µs (SLO: <30.000µs 📉 -40.4%) vs baseline: -0.8% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 2.451µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.155µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +21.7% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -0.3% Memory: ✅ 41.642MB (SLO: <43.500MB -4.3%) vs baseline: +5.4% ✅ ospathjoin_aspectTime: ✅ 6.259µs (SLO: <10.000µs 📉 -37.4%) vs baseline: +0.1% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.5% ✅ ospathjoin_noaspectTime: ✅ 6.311µs (SLO: <10.000µs 📉 -36.9%) vs baseline: ~same Memory: ✅ 41.563MB (SLO: <43.500MB -4.5%) vs baseline: +4.6% ✅ ospathnormcase_aspectTime: ✅ 3.572µs (SLO: <10.000µs 📉 -64.3%) vs baseline: +0.4% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 3.609µs (SLO: <10.000µs 📉 -63.9%) vs baseline: +0.3% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.890µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -0.1% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 5.018µs (SLO: <10.000µs 📉 -49.8%) vs baseline: +0.3% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.777µs (SLO: <10.000µs 📉 -62.2%) vs baseline: +1.2% Memory: ✅ 41.583MB (SLO: <43.500MB -4.4%) vs baseline: +5.3% ✅ ospathsplitdrive_noaspectTime: ✅ 0.753µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.3% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.3% ✅ ospathsplitext_aspectTime: ✅ 4.607µs (SLO: <10.000µs 📉 -53.9%) vs baseline: -0.3% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 4.594µs (SLO: <10.000µs 📉 -54.1%) vs baseline: -1.2% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.373µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +13.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 201.910µs (SLO: <220.000µs -8.2%) vs baseline: +0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.317µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.4% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.073µs (SLO: <230.000µs -7.4%) vs baseline: -0.8% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.185µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.686µs (SLO: <150.000µs -8.9%) vs baseline: +0.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.108µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -0.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 212.642µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -1.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ 100-count-metrics-100-timesTime: ✅ 20.014ms (SLO: <22.000ms -9.0%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.208ms (SLO: <2.550ms 📉 -13.4%) vs baseline: -1.1% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.401ms (SLO: <1.550ms -9.6%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.191ms (SLO: <2.550ms 📉 -14.1%) vs baseline: +0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.545µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +0.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 172.728µs (SLO: <250.000µs 📉 -30.9%) vs baseline: +0.2% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +5.2% ✅ flush-1000-metricsTime: ✅ 2.172ms (SLO: <2.500ms 📉 -13.1%) vs baseline: ~same Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.1% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Addresses the issue noticed in #15543 where #9534 introduced a change that fails to add the user id if it isn't an int.
Today, if we pass in UUIDs in a user model, the assertion fails:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1311372628
Testing
Locally, I tested with
riot shell <hash>because the normal riot command was failing to download all the prereqs correctly.Risks
Additional Notes
Once I have the fix in this commit, I still need to check with @christophe-papazian on the approach.