-
Notifications
You must be signed in to change notification settings - Fork 475
refactor(profiling): use custom std::deque-like data structure #15748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(profiling): use custom std::deque-like data structure #15748
Conversation
|
|
c87face to
64dd39d
Compare
Performance SLOsComparing candidate kowalski/refactor-profiling-use-custom-std-deque-like-data-structure (1ff46f5) with baseline main (3841a70) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.785µs (SLO: <20.000µs 📉 -11.1%) vs baseline: 📈 +20.1% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 14.887µs (SLO: <20.000µs 📉 -25.6%) vs baseline: -0.7% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.340µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +1.0% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.545µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.5% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 17.959µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 24.021µs (SLO: <30.000µs 📉 -19.9%) vs baseline: +1.0% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 2.754µs (SLO: <10.000µs 📉 -72.5%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 1.454µs (SLO: <10.000µs 📉 -85.5%) vs baseline: -0.8% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 16.711µs (SLO: <20.000µs 📉 -16.4%) vs baseline: +0.6% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 1.417µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 55.539µs (SLO: <70.000µs 📉 -20.7%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 3.256µs (SLO: <10.000µs 📉 -67.4%) vs baseline: -0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 14.608µs (SLO: <20.000µs 📉 -27.0%) vs baseline: -0.4% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 2.593µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 14.462µs (SLO: <20.000µs 📉 -27.7%) vs baseline: -0.6% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 3.124µs (SLO: <10.000µs 📉 -68.8%) vs baseline: -1.9% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 15.640µs (SLO: <30.000µs 📉 -47.9%) vs baseline: +0.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.609µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 18.125µs (SLO: <30.000µs 📉 -39.6%) vs baseline: 📈 +22.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.501µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.1% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 171.004µs (SLO: <200.000µs 📉 -14.5%) vs baseline: -0.1% Memory: ✅ 43.155MB (SLO: <43.250MB 🟡 -0.2%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 190.865µs (SLO: <200.000µs -4.6%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 3.802µs (SLO: <10.000µs 📉 -62.0%) vs baseline: +1.4% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 3.162µs (SLO: <10.000µs 📉 -68.4%) vs baseline: -0.1% Memory: ✅ 43.057MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.291µs (SLO: <20.000µs 📉 -23.5%) vs baseline: +0.3% Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.465µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 17.059µs (SLO: <20.000µs 📉 -14.7%) vs baseline: -0.5% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 1.562µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.6% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.809µs (SLO: <30.000µs 📉 -30.6%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 2.719µs (SLO: <10.000µs 📉 -72.8%) vs baseline: +0.9% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.861µs (SLO: <30.000µs 📉 -40.5%) vs baseline: +0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 2.420µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -1.0% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 17.670µs (SLO: <20.000µs 📉 -11.6%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 1.868µs (SLO: <10.000µs 📉 -81.3%) vs baseline: +0.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 166.176µs (SLO: <200.000µs 📉 -16.9%) vs baseline: ~same Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.386µs (SLO: <200.000µs 📉 -12.8%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 168.636µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 43.136MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.404µs (SLO: <200.000µs 📉 -13.8%) vs baseline: +0.3% Memory: ✅ 43.175MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.759µs (SLO: <10.000µs 📉 -62.4%) vs baseline: +2.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 212.265µs (SLO: <300.000µs 📉 -29.2%) vs baseline: ~same Memory: ✅ 43.136MB (SLO: <44.000MB 🟡 -2.0%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 2.918µs (SLO: <10.000µs 📉 -70.8%) vs baseline: +0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.521µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.8% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 19.013µs (SLO: <30.000µs 📉 -36.6%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 2.021µs (SLO: <10.000µs 📉 -79.8%) vs baseline: +4.5% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.831µs (SLO: <20.000µs 📉 -20.8%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.5% ✅ slice_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 53.689µs (SLO: <80.000µs 📉 -32.9%) vs baseline: -0.6% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 3.607µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -0.8% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 17.605µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -0.3% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 1.854µs (SLO: <10.000µs 📉 -81.5%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ swapcase_aspectTime: ✅ 18.499µs (SLO: <30.000µs 📉 -38.3%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 2.790µs (SLO: <10.000µs 📉 -72.1%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 22.053µs (SLO: <30.000µs 📉 -26.5%) vs baseline: 📈 +20.8% Memory: ✅ 42.939MB (SLO: <43.000MB 🟡 -0.1%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 2.671µs (SLO: <10.000µs 📉 -73.3%) vs baseline: -1.1% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 20.546µs (SLO: <30.000µs 📉 -31.5%) vs baseline: +0.5% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.311µs (SLO: <10.000µs 📉 -56.9%) vs baseline: -0.8% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 17.947µs (SLO: <30.000µs 📉 -40.2%) vs baseline: +0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 2.438µs (SLO: <10.000µs 📉 -75.6%) vs baseline: -0.7% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.185µs (SLO: <10.000µs 📉 -48.2%) vs baseline: 📈 +22.3% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 4.274µs (SLO: <10.000µs 📉 -57.3%) vs baseline: -1.3% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.200µs (SLO: <10.000µs 📉 -38.0%) vs baseline: -1.1% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 6.321µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.7% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.594µs (SLO: <10.000µs 📉 -64.1%) vs baseline: +0.6% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.616µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.4% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.889µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -0.2% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 5.022µs (SLO: <10.000µs 📉 -49.8%) vs baseline: +0.3% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.738µs (SLO: <10.000µs 📉 -62.6%) vs baseline: +0.4% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.749µs (SLO: <10.000µs 📉 -92.5%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.664µs (SLO: <10.000µs 📉 -53.4%) vs baseline: +1.3% Memory: ✅ 41.543MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 4.607µs (SLO: <10.000µs 📉 -53.9%) vs baseline: -0.7% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.362µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +12.3% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 1-count-metrics-100-timesTime: ✅ 198.316µs (SLO: <220.000µs -9.9%) vs baseline: -0.6% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.291µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -1.1% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.102µs (SLO: <230.000µs -6.9%) vs baseline: -0.2% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.160µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.100µs (SLO: <150.000µs -9.3%) vs baseline: -0.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.110µs (SLO: <20.000µs 📉 -84.4%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-rate-metrics-100-timesTime: ✅ 211.632µs (SLO: <250.000µs 📉 -15.3%) vs baseline: -0.9% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ 100-count-metrics-100-timesTime: ✅ 19.966ms (SLO: <22.000ms -9.2%) vs baseline: -0.1% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.219ms (SLO: <2.550ms 📉 -13.0%) vs baseline: +0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.224ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +2.0% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.580µs (SLO: <20.000µs 📉 -77.1%) vs baseline: -0.9% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 174.662µs (SLO: <250.000µs 📉 -30.1%) vs baseline: +0.2% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.178ms (SLO: <2.500ms 📉 -12.9%) vs baseline: +0.4% Memory: ✅ 36.117MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +5.0% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
ef99394 to
782e2d7
Compare
782e2d7 to
5acbd98
Compare
Description
Testing
Risks
Additional Notes