-
Notifications
You must be signed in to change notification settings - Fork 476
fix(falcon): fix v1 service naming #15815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate munir/fix-falcon-v1-service-naming (5979bc6) with baseline main (b1bcf6a) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.957µs (SLO: <20.000µs 📉 -10.2%) vs baseline: 📈 +21.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +5.5% ✅ add_inplace_aspectTime: ✅ 14.957µs (SLO: <20.000µs 📉 -25.2%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.341µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +1.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 17.966µs (SLO: <30.000µs 📉 -40.1%) vs baseline: +0.6% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 24.003µs (SLO: <30.000µs 📉 -20.0%) vs baseline: +0.8% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 2.773µs (SLO: <10.000µs 📉 -72.3%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.478µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -0.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 16.531µs (SLO: <20.000µs 📉 -17.3%) vs baseline: -1.0% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 1.415µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 55.656µs (SLO: <70.000µs 📉 -20.5%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 3.286µs (SLO: <10.000µs 📉 -67.1%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 14.646µs (SLO: <20.000µs 📉 -26.8%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 2.602µs (SLO: <10.000µs 📉 -74.0%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 14.749µs (SLO: <20.000µs 📉 -26.3%) vs baseline: +0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 3.158µs (SLO: <10.000µs 📉 -68.4%) vs baseline: +0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 15.626µs (SLO: <30.000µs 📉 -47.9%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.8% ✅ decode_noaspectTime: ✅ 1.614µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +2.9% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 18.161µs (SLO: <30.000µs 📉 -39.5%) vs baseline: 📈 +23.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +5.7% ✅ encode_noaspectTime: ✅ 1.501µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +0.3% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 171.222µs (SLO: <200.000µs 📉 -14.4%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.4% ✅ format_map_aspectTime: ✅ 190.996µs (SLO: <200.000µs -4.5%) vs baseline: -0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 3.783µs (SLO: <10.000µs 📉 -62.2%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 3.132µs (SLO: <10.000µs 📉 -68.7%) vs baseline: -0.9% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 15.340µs (SLO: <20.000µs 📉 -23.3%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +6.0% ✅ index_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 17.031µs (SLO: <20.000µs 📉 -14.8%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.9% ✅ join_noaspectTime: ✅ 1.568µs (SLO: <10.000µs 📉 -84.3%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +5.8% ✅ ljust_aspectTime: ✅ 20.760µs (SLO: <30.000µs 📉 -30.8%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.4% ✅ ljust_noaspectTime: ✅ 2.713µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 17.892µs (SLO: <30.000µs 📉 -40.4%) vs baseline: +0.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +5.2% ✅ lower_noaspectTime: ✅ 2.417µs (SLO: <10.000µs 📉 -75.8%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 21.787µs (SLO: <30.000µs 📉 -27.4%) vs baseline: 📈 +23.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +5.7% ✅ lstrip_noaspectTime: ✅ 1.864µs (SLO: <10.000µs 📉 -81.4%) vs baseline: +0.9% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 166.080µs (SLO: <200.000µs 📉 -17.0%) vs baseline: -0.1% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.348µs (SLO: <200.000µs 📉 -12.8%) vs baseline: ~same Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.4% ✅ modulo_aspect_for_bytesTime: ✅ 168.400µs (SLO: <200.000µs 📉 -15.8%) vs baseline: -0.2% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.011µs (SLO: <200.000µs 📉 -14.0%) vs baseline: +0.2% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 3.645µs (SLO: <10.000µs 📉 -63.6%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 212.112µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <44.000MB -3.1%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 2.908µs (SLO: <10.000µs 📉 -70.9%) vs baseline: +0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 1.465µs (SLO: <10.000µs 📉 -85.4%) vs baseline: +2.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.525µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 19.114µs (SLO: <30.000µs 📉 -36.3%) vs baseline: +1.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.8% ✅ rstrip_noaspectTime: ✅ 1.937µs (SLO: <10.000µs 📉 -80.6%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 15.858µs (SLO: <20.000µs 📉 -20.7%) vs baseline: -0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.9% ✅ slice_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -1.0% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 53.600µs (SLO: <80.000µs 📉 -33.0%) vs baseline: -0.7% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 3.634µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ strip_aspectTime: ✅ 17.698µs (SLO: <20.000µs 📉 -11.5%) vs baseline: -0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.8% ✅ strip_noaspectTime: ✅ 1.890µs (SLO: <10.000µs 📉 -81.1%) vs baseline: +1.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.5% ✅ swapcase_aspectTime: ✅ 18.546µs (SLO: <30.000µs 📉 -38.2%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.780µs (SLO: <10.000µs 📉 -72.2%) vs baseline: -1.0% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ title_aspectTime: ✅ 18.274µs (SLO: <30.000µs 📉 -39.1%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.000MB 🟡 -1.0%) vs baseline: +5.5% ✅ title_noaspectTime: ✅ 2.642µs (SLO: <10.000µs 📉 -73.6%) vs baseline: -1.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 20.593µs (SLO: <30.000µs 📉 -31.4%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 4.367µs (SLO: <10.000µs 📉 -56.3%) vs baseline: +0.7% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 17.912µs (SLO: <30.000µs 📉 -40.3%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +6.0% ✅ upper_noaspectTime: ✅ 2.681µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +9.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.201µs (SLO: <10.000µs 📉 -48.0%) vs baseline: 📈 +22.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 4.308µs (SLO: <10.000µs 📉 -56.9%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.227µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.8% Memory: ✅ 42.467MB (SLO: <43.500MB -2.4%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 6.265µs (SLO: <10.000µs 📉 -37.3%) vs baseline: -0.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.558µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.606µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -1.2% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.3% ✅ ospathsplit_aspectTime: ✅ 4.937µs (SLO: <10.000µs 📉 -50.6%) vs baseline: +0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 5.037µs (SLO: <10.000µs 📉 -49.6%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.785µs (SLO: <10.000µs 📉 -62.1%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.753µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.621µs (SLO: <10.000µs 📉 -53.8%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 4.661µs (SLO: <10.000µs 📉 -53.4%) vs baseline: +0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.348µs (SLO: <20.000µs 📉 -83.3%) vs baseline: 📈 +13.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 199.567µs (SLO: <220.000µs -9.3%) vs baseline: +0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.300µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.219µs (SLO: <230.000µs -7.7%) vs baseline: -0.5% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.184µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.3% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.062µs (SLO: <150.000µs -9.3%) vs baseline: -0.1% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.102µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.288µs (SLO: <250.000µs 📉 -14.7%) vs baseline: -0.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.034ms (SLO: <22.000ms -8.9%) vs baseline: +0.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.230ms (SLO: <2.550ms 📉 -12.5%) vs baseline: -1.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.402ms (SLO: <1.550ms -9.5%) vs baseline: +0.6% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.192ms (SLO: <2.550ms 📉 -14.0%) vs baseline: +0.6% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.4% ✅ flush-1-metricTime: ✅ 4.574µs (SLO: <20.000µs 📉 -77.1%) vs baseline: -0.7% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.183µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.8% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.189ms (SLO: <2.500ms 📉 -12.4%) vs baseline: +0.6% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.6% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Fixes
DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLEDsupport for the falcon integration.Previously, falcon auto-instrumentation passed a default service name of
"falcon"to theTraceMiddleware. This prevented service name schematization from executing, resulting in the default service name of"falcon"always being set regardless of configuration.Testing
Added schematization tests for falcon.
Risks
None
Additional Notes
None