[DOCS-10446] changes to Resource Catalog policies #28389
Conversation
github-actions
bot
added
Architecture
Preview links (active after the
|
There was a problem hiding this comment.
Looks good overall, just left a few suggestions.
Also, as a recommendation for future image maintenance, you can remove the Preview elements from the UI before taking a screenshot. I believe that the Pawparazzi tool offers this functionality, but you can also do it through the console in developer tools. It's not critical, but it helps your images stay current for longer, since these elements will eventually be removed. Let me know if you have any questions!
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
|
Thank you for the review @buraizu ! This is ready for re-review. |
There was a problem hiding this comment.
@aliciascott thanks for applying those changes! I just noticed another minor issue that slipped past me the first time, as well as some duplicated text in the new content. Let me know if you have any feedback or questions!
| * **Use advanced condition matching**: | ||
| Use operators like `\>, \<, \!=` (for example enforcing Kubernetes version \> 1.25). | ||
| Use advanced condition matching: Use operators like `>, <`, or `!=` (for example, enforcing Kubernetes version > 1.25). |
There was a problem hiding this comment.
| Use advanced condition matching: Use operators like `>, <`, or `!=` (for example, enforcing Kubernetes version > 1.25). | |
| Use operators like `>`, `<`, or `!=` (for example, enforcing Kubernetes version > 1.25). |
There was a problem hiding this comment.
This is a duplicate of the line above.
Also, just to confirm -- is it intentional to have the first two operators share the same code block, but the last operator is in its own code block? I re-added the backticks I previously suggested if not, but let me know if there might be some context I'm missing here.
There was a problem hiding this comment.
Ah so yes this was from the PM, the operator should be < , > basically the greater than and less than operator, I don't think it matters if they are together or separate but just to be consistent. I agree one sentence is duplicated. let me check this.
There was a problem hiding this comment.
Thanks for following up! I did some looking into this, and <, > are indeed two separate operators. Ideally, for visual clarity and consistency, they should each have their own set of backticks as I suggested above. Screenshot for reference:
Let me know if you have any feedback!
Co-authored-by: Bryce Eadie <[email protected]>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: waiting
and removed
mergequeue-status: waiting
labels
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
…kretvix/dsm-add-new-technology-pages * 'master' of github.com:DataDog/documentation: (33 commits) Update databricks.md (#28979) [SCA] Change Repo Settings Link in SCA Setup + Troubleshooting page (#28975) add recommendation for RabbitMQ integration (#28945) add warning for openai byok (#28813) SDCD-1160: specifying dora change lead time limitation if previous deployment was too far in the past (#28956) Add helm to argocd docs (#28630) added that TCP is not available for gov site (#28972) Translation Pipeline PR (#28965) Update explorer.md (#28970) [DOCS-10642] Add Snowflake section to OP Amazon S3 destination (#28967) remove "preview" callout from datastore docs (#28963) Update check_references.md (#28855) Update Private Location Windows version to 1.56.1 (#28950) Improve Cdocs logging to catch environment issues (#28961) [DOCS-10446] changes to Resource Catalog policies (#28389) Add code snippet for Kotlin Multiplatform (#28954) minor rum edits (#28106) [DOCS-10699] add regions to restricted networks page (#28958) [DJM-218] Remove install logs section in Databricks page (#28948) [Debugger] Bump minimum Node.js tracer version (#28957) ...
What does this PR do? What is the motivation?
This PR updates the Governance page to the new name "Policies", adds alias to the old page/URL, updates screenshots and copy throughout the relevant pages to reflect the new name.
Also adds new instructions for creating a custom policy.
Note for reviewer/OC: There are some newer changes with the top Nav for Resource Catalog as well as the Security tab has been removed. Working with the PM we are electing to iterate on these changes to get the copy out for the new Policies tab, then will create a new PR to do the Security tab changes.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes