Skip to content

[SDCI-1360] Add critical path and exec time feature support #28922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rodrigo-roca
Copy link
Contributor

@rodrigo-roca rodrigo-roca commented Apr 23, 2025

What does this PR do? What is the motivation?

We are extending the support of 2 features: critical path and execution time. Those 2 were only available for the Gitlab CI provider, now we support all the CI providers.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@rodrigo-roca rodrigo-roca marked this pull request as ready for review April 23, 2025 12:05
@rodrigo-roca rodrigo-roca requested review from a team as code owners April 23, 2025 12:05
@rodrigo-roca rodrigo-roca requested a review from liashenko April 23, 2025 12:05
<div class="alert alert-info">If you are interested in critical path but your CI provider is not supported yet, fill out <a href="https://forms.gle/zDgiDSGQxA1HgjXh6" target="_blank">this form</a>.</div>

Even without Filtering and computing Exclusive Time, you can still [highlight which CI jobs are on the critical path][4] using the Pipeline Execution detail view across all CI providers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now support every CI provider I thought it was better to just remove this instead of saying "we support all CI providers"

@rodrigo-roca
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2025

View all feedbacks in Devflow UI.

2025-04-24 13:57:50 UTC ℹ️ Start processing command /merge


2025-04-24 13:57:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-24 14:14:19 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
GitHub returned an error during the merge attempt. This is a known issue that can often be resolved by retrying the merge request in an hour.

Details

Error: PUT https://api.github.com/repos/DataDog/documentation/pulls/28922/merge: 405 Merge already in progress []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-585c5d9795-ngjkq@): PUT https://api.github.com/repos/DataDog/documentation/pulls/28922/merge: 405 Merge already in progress [] (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/documentation/pulls/28922/merge: 405 Merge already in progress [] (type: ErrorResponse, retryable: true)

@rodrigo-roca
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2025

View all feedbacks in Devflow UI.

2025-04-24 14:31:37 UTC ℹ️ Start processing command /merge


2025-04-24 14:31:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-24 14:48:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cbe730c into master Apr 24, 2025
23 of 30 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rodrigo.roca/enable-critical-path-and-exec-time-all-providers branch April 24, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants