Skip to content

Upgrade coverage dependency #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Upgrade coverage dependency #5647

merged 4 commits into from
Feb 5, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 5, 2020

Motivation

We can workaround the concurrency bug nedbat/coveragepy#883 (comment)

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #5647 into master will decrease coverage by 7%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/tests/test_docker.py 48.14% <0%> (-51.86%) ⬇️
datadog_checks_dev/tests/test__env.py 100% <0%> (ø) ⬆️
datadog_checks_dev/tests/test_structures.py 100% <0%> (ø) ⬆️
datadog_checks_dev/datadog_checks/dev/env.py 22.72% <0%> (-20.46%) ⬇️
datadog_checks_dev/tests/test_conditions.py 82.25% <0%> (-17.75%) ⬇️
datadog_checks_dev/datadog_checks/dev/docker.py 24.57% <0%> (-19.5%) ⬇️
...atadog_checks_dev/datadog_checks/dev/subprocess.py 62.16% <0%> (-16.22%) ⬇️
...checks_dev/tests/plugin/test_environment_runner.py 100% <0%> (ø) ⬆️
...atadog_checks_dev/datadog_checks/dev/structures.py 68.85% <0%> (-13.12%) ⬇️
datadog_checks_dev/datadog_checks/dev/_env.py 54.16% <0%> (-9.73%) ⬇️
... and 1005 more

@@ -1,5 +1,6 @@
[run]
branch = True
parallel = True
Copy link
Member

@AlexandreYang AlexandreYang Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment that this has been added as workaround and link to the original issue?

That will help future readers and also help clean up when the issue is resolved.

@ofek ofek merged commit 5840877 into master Feb 5, 2020
@ofek ofek deleted the ofek/c branch February 5, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants