Typecheck and test improvements #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was confusing/unclear that some directories were for testing the tamr_client package and others for tamr_unify_client package.
Packages should be typechecked with `--package` flag. Previously, a typecheck error in attribute.py went unnoticed by mypy. Additionally, for `--package` to work, __init__.py files are required (at least for now, see python/mypy#5759 ).
...should return a tuple of 1 *or more* attributes. The correct syntax for this is `Tuple[<type>, ...]` not `Tuple[<type>]`
Users autocompleting `tc.` won't get results like `tc.os` like before since that `os` import was for the BETA check that is now in a separate module. Also, reorder tamr_client/__init__.py with comment headers for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR fixes typechecking for the
tamr_clientpackage (and corresponding tests). Previously, some typechecking errors went unnoticed bymypydue to knownmypy --packagebugs (see python/mypy#5759 ).Also, move all
tamr_clienttests out of the globaltestsnamespace and into their own top-level namespace:tests/tamr_client.Finally, move BETA check into a function in its own module so that
tamr_client.__init__.pydoes not have extraneous imports/code that users who are autocompletingtc.could erroneously think are part of the intended interface.✔️ PR Todo
-devversion:[#<issue number>](<link to issue>) <change description>