MVC Context in Handler #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the delay. I'll give this my full attention and help get this merged. |
DavidParks8
requested changes
Sep 7, 2019
src/Microsoft.Owin.Security.Authorization.Mvc/ResourceAuthorizeAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Owin.Security.Authorization.Mvc/ResourceAuthorizeAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Owin.Security.Authorization.Mvc/ResourceAuthorizeAttribute.cs
Outdated
Show resolved
Hide resolved
Owner
|
/AzurePipelines run |
DavidParks8
reviewed
Sep 7, 2019
| /// This value is <value>true</value> when the <paramref name="user"/> fulfills the <paramref name="authorizeAttribute"/>; otherwise <value>false</value>. | ||
| /// </returns> | ||
| Task<bool> IsAuthorizedAsync(IAuthorizationController controller, ClaimsPrincipal user, IAuthorizeData authorizeAttribute); | ||
| Task<bool> IsAuthorizedAsync(IAuthorizationController controller, ClaimsPrincipal user, IAuthorizeData authorizeAttribute, object resource = null); |
Owner
There was a problem hiding this comment.
From the build logs:
##[warning]Microsoft.Design : Replace method 'IResourceAuthorizationHelper.IsAuthorizedAsync(IAuthorizationController, ClaimsPrincipal, IAuthorizeData, object)' with an overload that supplies all default arguments.
Contributor
Author
There was a problem hiding this comment.
Sorry for the delay,
I have fixed it, I guess I screwed up during my initial commit. Thank you for your patience.
…eAttribute.cs Co-Authored-By: David Parks <[email protected]>
…eAttribute.cs Co-Authored-By: David Parks <[email protected]>
…eAttribute.cs Co-Authored-By: David Parks <[email protected]>
|
Great feature, thanks for the effort you put in it! |
DavidParks8
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the filterContext or actionContext for MVC and WebApi respectively as a resource in the handler when using ResourceAuthorize.