Fix cobertura_report collection error because of earlier error, before tests #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tests CoberturaPublisher is done at the end of the execution because it cannot be duplicated (at least it was the case several years ago when it was plugged-in). With 1f3c17d / #482 we tried to eagerly collect tests results even when tests failed, but didn't properly handle that late collection in the case of errors before any test step: the tests results won't exist. Because it's a global, late collection, we cannot do the fancy double collection with/without error propagation that we did in #482 for the other tests results collections. That's OK; the situation is explained to the user.
thomas-riccardi
force-pushed
the
dev-fix-cobertura-report-collection-error-jenkins
branch
from
5c7a69b to
f18ab63
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
nl2412
approved these changes
Mar 12, 2021
thomas-riccardi
deleted the
dev-fix-cobertura-report-collection-error-jenkins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoberturaPublisher is done at the end of the execution because it
cannot be duplicated (at least it was the case several years ago when
it was plugged-in).
With 1f3c17d / #482 we tried to
eagerly collect tests results even when tests failed, but didn't
properly handle that late collection in the case of errors before any
test step: the tests results won't exist.
Because it's a global, late collection, we cannot do the fancy double
collection with/without error propagation that we did in #482 for the
other tests results collections.
That's OK; the situation is explained to the user.