[plotly.js] Update to include sunburst specific properties and sunburstclick event#48963
Conversation
|
@LittleMikeDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 48963,
"author": "LittleMikeDev",
"owners": [
"chrisgervang",
"martinduparc",
"frederikaalund",
"taoqf",
"Dadstart",
"szechyjs",
"MercifulCode",
"soorajpudiyadath",
"jonfreedman",
"meganrm",
"milesjos",
"skippercool",
"zeroyoichihachi",
"mtadams007",
"marnett-git",
"peterblazejewicz",
"brammitch",
"blizzardjessica",
"olegshilov"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "abb3d7a",
"headCommitOid": "abb3d7a335d14bd2efb4d900708f405ddc3cb42c",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-10-20T19:06:12.000Z",
"lastCommentDate": "2020-10-28T17:49:04.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48963/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Popular",
"newPackages": [],
"packages": [
"plotly.js"
],
"files": [
{
"path": "types/plotly.js/index.d.ts",
"kind": "definition",
"package": "plotly.js"
},
{
"path": "types/plotly.js/test/index-tests.ts",
"kind": "test",
"package": "plotly.js"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-10-28T17:48:11.000Z",
"firstApprovalDate": "2020-10-28T17:48:11.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @MercifulCode @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @zeroyoichihachi @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov — please review this PR in the next few days. Be sure to explicitly select |
|
@LittleMikeDev Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @MercifulCode, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @zeroyoichihachi, @mtadams007, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov: you can do this too.) |
|
Ready to merge |
|
I just published |
The documentation on sunburst point data seems to be non-existent, and it seems to have very different properties to the existing
PlotDatumdefinition (the docs say that it depends on trace type) so I made a newSunburstPlotDatumdefinition with all the properties I could sensibly figure out! Descriptions are in the test. Hope this is suitable!npm test YOUR_PACKAGE_NAME.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
Improve sunbust and treemap click events behavior plotly/plotly.js#4454
https://plotly.com/javascript/plotlyjs-events/#event-data
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.