-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Update type definitions for Redux #7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
react-redux/react-redux.d.ts to author (@tkqubo). Could you review this PR? Checklist
react-router-redux/react-router-redux.d.ts to authors (@isman-usoh @noah79 @rosendi). Could you review this PR? Checklist
redux-devtools/redux-devtools.d.ts to author (@mc-petry). Could you review this PR? Checklist
redux-form/redux-form.d.ts to author (@aikoven). Could you review this PR? Checklist
redux/redux.d.ts to authors (@wbuchwalter @Keats). Could you review this PR? Checklist
|
|
What about PR #6629 ? |
@wbuchwalter I left a comment there, please see: #6629 (comment) |
👍 We should go ahead with that one, the other PR has been stuck in limbo for too long. |
I took a quick glance and things looked fine for me. I didn't actually check it against my existing code...but I didn't see any obvious problems. I hope this one doesn't get stuck in limbo like #6629. I'll add a comment to that pull request directing people here. |
Can you please refresh this PR and address merge conflicts. |
@mhegazy Shouldn't we close this PR instead? And just copy paste Redux's typings from the official repo? |
|
|
@wbuchwalter is right, closing this. |
Multiple updates and refinement for Redux typings.
Introduces stronger types employing generics as well as Redux API updates.