Skip to content

Update type definitions for Redux #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aikoven
Copy link
Contributor

@aikoven aikoven commented Feb 1, 2016

Multiple updates and refinement for Redux typings.
Introduces stronger types employing generics as well as Redux API updates.

@dt-bot
Copy link
Member

dt-bot commented Feb 1, 2016

react-redux/react-redux.d.ts

to author (@tkqubo). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

react-router-redux/react-router-redux.d.ts

to authors (@isman-usoh @noah79 @rosendi). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

redux-devtools/redux-devtools.d.ts

to author (@mc-petry). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

redux-form/redux-form.d.ts

to author (@aikoven). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

redux/redux.d.ts

to authors (@wbuchwalter @Keats). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@tkqubo
Copy link
Contributor

tkqubo commented Feb 1, 2016

react-redux/react-redux.d.ts looks 👍

@wbuchwalter
Copy link
Contributor

What about PR #6629 ?

@aikoven
Copy link
Contributor Author

aikoven commented Feb 2, 2016

@wbuchwalter I left a comment there, please see: #6629 (comment)

@wbuchwalter
Copy link
Contributor

👍 We should go ahead with that one, the other PR has been stuck in limbo for too long.

@xogeny
Copy link
Contributor

xogeny commented Feb 6, 2016

I took a quick glance and things looked fine for me. I didn't actually check it against my existing code...but I didn't see any obvious problems. I hope this one doesn't get stuck in limbo like #6629. I'll add a comment to that pull request directing people here.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 27, 2016

Can you please refresh this PR and address merge conflicts.

@mhegazy mhegazy added the Revision needed This PR needs code changes before it can be merged. label Jun 27, 2016
@wbuchwalter
Copy link
Contributor

wbuchwalter commented Jun 27, 2016

@mhegazy Shouldn't we close this PR instead? And just copy paste Redux's typings from the official repo?

@isman-usoh
Copy link
Contributor

react-router-redux/react-router-redux.d.ts 👍

@mc-petry
Copy link
Contributor

redux-devtools/redux-devtools.d.ts 👍

@aikoven
Copy link
Contributor Author

aikoven commented Jun 27, 2016

@wbuchwalter is right, closing this.

@aikoven aikoven closed this Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants