Quadtree read/write, no build #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reased readability)
|
Done
Not working/testes:
|
roeldegoede
commented
Dec 3, 2024
…ult but using another cartopy projection
roeldegoede
commented
Dec 20, 2024
Leynse
approved these changes
Dec 20, 2024
* bugfix so that the .nc file is closed automatically when erroring or when leaving the context manager (with block). see pydata/xarray#1629 (comment) * fixed all occurences of xr.opendataset with the safe open&close pattern * review comments by Roel * fix linting --------- Co-authored-by: roeldegoede <[email protected]>
2 tasks
roeldegoede
commented
Jan 15, 2025
hydromt_sfincs/sfincs.py
Outdated
| @@ -3126,7 +3196,7 @@ def read_forcing(self, data_vars: List = None): | |||
| elif name in ["netbndbzsbzi", "netsrcdis"]: | |||
| ds = GeoDataset.from_netcdf(fn, crs=self.crs, chunks="auto") | |||
| else: | |||
| ds = xr.open_dataset(fn, chunks="auto") | |||
| ds = xr.load_dataset(fn, chunks="auto") | |||
There was a problem hiding this comment.
@LuukBlom zou dit niet ook zo'n indented statement geweest moeten zijn?
There was a problem hiding this comment.
Nee, hier wordt in 1x de hele ds geladen, dus load_dataset is prima hier vgm.
docs xarray zeggen dit:
Open, load into memory, and close a Dataset from a file or file-like object.
This is a thin wrapper around open_dataset(). It differs from open_dataset in that it loads the Dataset into memory, closes the file, and returns the Dataset. In contrast, open_dataset keeps the file handle open and lazy loads its contents. All parameters are passed directly to open_dataset. See that documentation for further details.
* added xu_open_dataset wrapper. * load_dataset -> open_dataset * linting --------- Co-authored-by: roeldegoede <[email protected]>
Closed
|
🎉 ❤️ |
LuukBlom
added a commit
to Deltares-research/FloodAdapt
that referenced
this pull request
Apr 30, 2025
Making this PR since I accidentally merged the workflow PR when we still have to wait on the hydromt_sfincs release. - [x] [this PR in hydromt_sfincs](Deltares/hydromt_sfincs#226) has to be merged and released to pypi. - [x] create and upload release of flood-adapt to pypi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.