Allow TYPE_CHECKING guards in match statements#1726
Merged
DetachHead merged 5 commits intoDetachHead:mainfrom Feb 18, 2026
Merged
Conversation
Contributor
grahamcracker1234
commented
Feb 10, 2026
grahamcracker1234
commented
- Closes TYPE_CHECKING guard not respected in match exhaustiveness / unreachable-code analysis #1715
This comment has been minimized.
This comment has been minimized.
DetachHead
reviewed
Feb 11, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DetachHead
reviewed
Feb 14, 2026
Comment on lines
+20603
to
+20606
| const suiteInNotTypeChecking = | ||
| node.d.suite.d.statements.length > 0 && isNotTypeCheckingBlock(node.d.suite.d.statements[0]); | ||
| if (subjectTypeResult.isIncomplete || suiteInNotTypeChecking) continue; | ||
| checkForUnusedPattern(evaluatorInterface, node.d.pattern, subjectType, node.parent.d.expr); |
Owner
There was a problem hiding this comment.
is there a reason to continue here instead of keeping the original logic? i think this might be causing the unintended changes from the primer
Suggested change
| const suiteInNotTypeChecking = | |
| node.d.suite.d.statements.length > 0 && isNotTypeCheckingBlock(node.d.suite.d.statements[0]); | |
| if (subjectTypeResult.isIncomplete || suiteInNotTypeChecking) continue; | |
| checkForUnusedPattern(evaluatorInterface, node.d.pattern, subjectType, node.parent.d.expr); | |
| const suiteInNotTypeChecking = | |
| node.d.suite.d.statements.length > 0 && isNotTypeCheckingBlock(node.d.suite.d.statements[0]); | |
| if (!subjectTypeResult.isIncomplete && !suiteInNotTypeChecking) { | |
| checkForUnusedPattern(evaluatorInterface, node.d.pattern, subjectType, node.parent.d.expr); | |
| } |
Contributor
Author
There was a problem hiding this comment.
I removed the continue
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.