refactor and fix bugs in CodeActionProvider#1753
Merged
DetachHead merged 6 commits intoDetachHead:mainfrom Mar 17, 2026
Merged
Conversation
1. reorganize every sub-operations to individual functions. this also fixes some actions missing due to early returns. 2. fix corrupt action order due to previous refactoring. now they can keep an order of "imports" - "regular fixes" - "ignore comments".
DetachHead
reviewed
Mar 15, 2026
Owner
DetachHead
left a comment
DetachHead
left a comment
There was a problem hiding this comment.
thanks! i wanted to split these code actions up into separate methods for a while
This comment has been minimized.
This comment has been minimized.
- remove redundant comments - disable ignore comment action for `reportImportCycles`
DetachHead
reviewed
Mar 15, 2026
This comment has been minimized.
This comment has been minimized.
declare returning arrays of actions in semantics
DetachHead
reviewed
Mar 17, 2026
This comment has been minimized.
This comment has been minimized.
DetachHead
approved these changes
Mar 17, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reportImportCyclesrule is forbidden now due to unstable behavior (see# pyright: ignore[reportImportCycles]doesn't work #1312)