fix typing_extensions auto-import#1754
Merged
DetachHead merged 1 commit intoDetachHead:mainfrom Mar 18, 2026
Merged
Conversation
was grouped with stdlib, now grouped with 3rd party
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
DetachHead
approved these changes
Mar 18, 2026
Owner
DetachHead
left a comment
There was a problem hiding this comment.
i'm on the fence about this. on one hand typing_extensions can be considered first-party since it's an official package maintained in the @python org. but since it doesn't actually come with python i can also understand why you'd want it to be considered third-party like every other pypi package.
it looks like ruff's unsorted-imports rule also considers it third party, so i'm happy to do the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeshed treats
typing_extensionsas stdlibSo when the auto-import inserts it, it inserts it in the stdlib section.
This fixes it to put it in the 3rd party section.
before:
after: