Skip to content

Comments

If determinate is false, pass --prefer-upstream#202

Merged
grahamc merged 5 commits intomainfrom
push-ysltloqzrqsn
Oct 25, 2025
Merged

If determinate is false, pass --prefer-upstream#202
grahamc merged 5 commits intomainfrom
push-ysltloqzrqsn

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Sep 10, 2025

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

  • Chores
    • Updated Nix installer configuration to v3.11.3 and increased required Nix version to 2.32.0.
    • Adjusted installer behavior to prefer upstream Nix when using non-determinate installation mode.

@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates GitHub Actions CI workflow configuration to migrate from nix-installer v0.18.0 to v3.11.3 and increases required Nix version to 2.32.0. It also introduces a new flag constant to prefer upstream Nix in the installer arguments when the determinate mode is disabled.

Changes

Cohort / File(s) Change Summary
CI Configuration Updates
.github/workflows/ci.yml
Migrates nix-installer from v0.18.0 to v3.11.3 across both install-nix and install-with-non-default-source-inputs matrices; updates Nix version requirement from 2.21.2/2.19.2 to 2.32.0; removes separate revision blocks and consolidates into url/nix-version pairs.
Installer Flag Addition
src/index.ts
Adds new FLAG_PREFER_UPSTREAM_NIX constant and incorporates it into installerArgs() method logic; when determinate mode is disabled, the flag is appended to installer arguments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Configuration updates are straightforward version/URL migrations with consistent patterns across matrices
  • TypeScript change introduces a single new constant with basic conditional logic in one code path
  • No complex interactions or ambiguous logic requiring deep analysis

Poem

🐰 A rabbit hops through nix so bright,
With v3.11.3 in sight!
New flags to prefer upstream's way,
When determinate takes holiday—
Our installer springs forth with delight!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-ysltloqzrqsn

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45a18a6 and f647679.

⛔ Files ignored due to path filters (1)
  • dist/index.js is excluded by !**/dist/**
📒 Files selected for processing (2)
  • .github/workflows/ci.yml (1 hunks)
  • src/index.ts (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@grahamc grahamc force-pushed the push-ysltloqzrqsn branch 2 times, most recently from 0d5286e to 5a09f65 Compare October 25, 2025 01:47
@grahamc grahamc marked this pull request as ready for review October 25, 2025 02:21
@grahamc grahamc merged commit 2fd3724 into main Oct 25, 2025
17 checks passed
@grahamc grahamc deleted the push-ysltloqzrqsn branch October 25, 2025 02:24
@coderabbitai coderabbitai bot mentioned this pull request Nov 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants