Skip to content

fixup: update upload_s3.sh to account for bucket policy changes#1603

Merged
grahamc merged 1 commit into
mainfrom
fixup-upload-script
Jul 10, 2025
Merged

fixup: update upload_s3.sh to account for bucket policy changes#1603
grahamc merged 1 commit into
mainfrom
fixup-upload-script

Conversation

@cole-h

@cole-h cole-h commented Jul 9, 2025

Copy link
Copy Markdown
Member
Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h cole-h added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Jul 9, 2025
@grahamc

grahamc commented Jul 9, 2025

Copy link
Copy Markdown
Member

Another option if you're into it is to use push-artifact-ids

@cole-h cole-h marked this pull request as ready for review July 9, 2025 18:00
@grahamc grahamc merged commit e55779f into main Jul 10, 2025
27 checks passed
@grahamc grahamc deleted the fixup-upload-script branch July 10, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grahamc grahamc grahamc approved these changes

Assignees

No one assigned

Labels

upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cole-h @grahamc