fix: improve json parsing error handling #231
Conversation
DevCycle/Models/UserConfig.swift
Outdated
| guard let variationName = dictionary["variationName"] else { throw UserConfigError.MissingProperty("variationName in Feature object") } | ||
| init (from dictionary: [String: Any]) throws { | ||
| guard let id = dictionary["_id"] as? String else { | ||
| throw UserConfigError.MissingProperty("_id in Feature object") |
There was a problem hiding this comment.
update these error messages to say we expect these to be typed as strings.
kaushalkapasi
force-pushed
the
fix-improve-json-parsing-error-handling
branch
from
af95065 to
60230d1
Compare
| } | ||
|
|
||
|
|
||
| func testSuccessfulConfigParsingWithNonStringValuesOnFeatures() throws { |
There was a problem hiding this comment.
can we actually add a test that uses test configs that have unknown properties in all parts of the config instead of just the feature?
There was a problem hiding this comment.
Yea can we add a test that shows it throwing for UserConfigError.InvalidProperty and UserConfigError.MissingProperty above? Also a test that shows that these errors don't propagate past the config fetching.
…coming User Configuration from the API
…ariables map parsing fails
…rom the user config
kaushalkapasi
force-pushed
the
fix-improve-json-parsing-error-handling
branch
from
b6e88cb to
57e2933
Compare
| self.features = features | ||
| } else { | ||
| Log.warn("Invalid feature map format", tags: ["config", "JSONParsing"]) | ||
| throw UserConfigError.InvalidProperty("features") |
There was a problem hiding this comment.
So where are these errors caught?
There was a problem hiding this comment.
These errors are caught by DevCycleService.getConfig completion handler of the method, defined as: completion: @escaping ConfigCompletionHandler)
kaushalkapasi
force-pushed
the
fix-improve-json-parsing-error-handling
branch
from
57e2933 to
deae363
Compare
[ String: Any ]to allow values to be of type other than Stringif letprotection when parsing thefeatureMapandvariablesMapon the UserConfig to prevent errors from JSON parsing to cause SDK crashes, instead we will log warnings