fix: use cached config if identify user fails #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalkapasi
changed the title
kaushalkapasi
force-pushed
the
fix-use-cached-config-on-identify-failure
branch
from
ad817d4 to
3498bee
Compare
jsalaber
approved these changes
Jun 10, 2025
kaushalkapasi
force-pushed
the
fix-use-cached-config-on-identify-failure
branch
from
3498bee to
e241997
Compare
kaushalkapasi
commented
Jun 10, 2025
| } | ||
| } | ||
| } catch { | ||
| Log.error("Error calling identifyUser for user_id \(String(describing: user.userId))", tags: ["identify"]) |
Collaborator
Author
There was a problem hiding this comment.
@jsalaber added this as well, logically I also want to use a cached config here in the event there is an error thrown, however would this be a duplication since its already called within the inner identifyUser?
Collaborator
There was a problem hiding this comment.
i think it's fine, it tells us the error came from the identifyUser
… fails for any reason
kaushalkapasi
force-pushed
the
fix-use-cached-config-on-identify-failure
branch
from
e241997 to
be8d98a
Compare
jonathannorris
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.