-
Notifications
You must be signed in to change notification settings - Fork 1
Creacion de componente cabecera(header) #10 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JhonasV
wants to merge
12
commits into
DevsDO:development
Choose a base branch
from
JhonasV:feature/10
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6c416de
feat: responsive header added
7e8e793
merged from upstream/development
1d9ab6c
yarn.lock merged conflict fix
cf24573
feat: header tests updated
8a0f7fb
feat: navbar tests added
36aeb35
feat: header siteTitle prop value updated
48c1647
feat:Props type added
9c691f9
feat: proptype removed
6c3563b
conflicts resolves
b8ff62f
remove unused imports and resolve merge conflicts
ee406bb
feat: Props type added
1e08a95
move react import to the file's first line
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
src/components/__tests__/__snapshots__/navbar.test.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`Navbar render correctly 1`] = ` | ||
| <ul | ||
| className="sc-bdnylx kxaAjQ" | ||
| open={false} | ||
| > | ||
| <li | ||
| className="sc-gtssRu krKCLp" | ||
| > | ||
| <span | ||
| className="sc-dlnjPT eJmKRn" | ||
| > | ||
| <a | ||
| href="https://github.com/DevsDO/whocode-frontend" | ||
| style={ | ||
| Object { | ||
| "textDecoration": "none", | ||
| } | ||
| } | ||
| target="_blank" | ||
| > | ||
| <svg | ||
| aria-hidden="true" | ||
| className="svg-inline--fa fa-github fa-w-16 " | ||
| data-icon="github" | ||
| data-prefix="fab" | ||
| focusable="false" | ||
| role="img" | ||
| style={Object {}} | ||
| viewBox="0 0 496 512" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path | ||
| d="M165.9 397.4c0 2-2.3 3.6-5.2 3.6-3.3.3-5.6-1.3-5.6-3.6 0-2 2.3-3.6 5.2-3.6 3-.3 5.6 1.3 5.6 3.6zm-31.1-4.5c-.7 2 1.3 4.3 4.3 4.9 2.6 1 5.6 0 6.2-2s-1.3-4.3-4.3-5.2c-2.6-.7-5.5.3-6.2 2.3zm44.2-1.7c-2.9.7-4.9 2.6-4.6 4.9.3 2 2.9 3.3 5.9 2.6 2.9-.7 4.9-2.6 4.6-4.6-.3-1.9-3-3.2-5.9-2.9zM244.8 8C106.1 8 0 113.3 0 252c0 110.9 69.8 205.8 169.5 239.2 12.8 2.3 17.3-5.6 17.3-12.1 0-6.2-.3-40.4-.3-61.4 0 0-70 15-84.7-29.8 0 0-11.4-29.1-27.8-36.6 0 0-22.9-15.7 1.6-15.4 0 0 24.9 2 38.6 25.8 21.9 38.6 58.6 27.5 72.9 20.9 2.3-16 8.8-27.1 16-33.7-55.9-6.2-112.3-14.3-112.3-110.5 0-27.5 7.6-41.3 23.6-58.9-2.6-6.5-11.1-33.3 2.6-67.9 20.9-6.5 69 27 69 27 20-5.6 41.5-8.5 62.8-8.5s42.8 2.9 62.8 8.5c0 0 48.1-33.6 69-27 13.7 34.7 5.2 61.4 2.6 67.9 16 17.7 25.8 31.5 25.8 58.9 0 96.5-58.9 104.2-114.8 110.5 9.2 7.9 17 22.9 17 46.4 0 33.7-.3 75.4-.3 83.6 0 6.5 4.6 14.4 17.3 12.1C428.2 457.8 496 362.9 496 252 496 113.3 383.5 8 244.8 8zM97.2 352.9c-1.3 1-1 3.3.7 5.2 1.6 1.6 3.9 2.3 5.2 1 1.3-1 1-3.3-.7-5.2-1.6-1.6-3.9-2.3-5.2-1zm-10.8-8.1c-.7 1.3.3 2.9 2.3 3.9 1.6 1 3.6.7 4.3-.7.7-1.3-.3-2.9-2.3-3.9-2-.6-3.6-.3-4.3.7zm32.4 35.6c-1.6 1.3-1 4.3 1.3 6.2 2.3 2.3 5.2 2.6 6.5 1 1.3-1.3.7-4.3-1.3-6.2-2.2-2.3-5.2-2.6-6.5-1zm-11.4-14.7c-1.6 1-1.6 3.6 0 5.9 1.6 2.3 4.3 3.3 5.6 2.3 1.6-1.3 1.6-3.9 0-6.2-1.4-2.3-4-3.3-5.6-2z" | ||
| fill="currentColor" | ||
| style={Object {}} | ||
| /> | ||
| </svg> | ||
| About | ||
| </a> | ||
| </span> | ||
| </li> | ||
| <li | ||
| className="sc-gtssRu krKCLp" | ||
| > | ||
| <span | ||
| className="sc-dlnjPT sc-hKFyIo eJmKRn fqRNey" | ||
| > | ||
| <a | ||
| href="/" | ||
| style={ | ||
| Object { | ||
| "color": "#fff", | ||
| "textDecoration": "none", | ||
| } | ||
| } | ||
| > | ||
| Nominate | ||
| </a> | ||
| </span> | ||
| </li> | ||
| </ul> | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,24 @@ | ||
| import * as React from "react" | ||
| import * as React from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import renderer from "react-test-renderer" | ||
|
|
||
| import renderer from "react-test-renderer"; | ||
| import Header from "../header"; | ||
|
|
||
| describe(`Header`, () => { | ||
| it(`renders siteTitle`, () => { | ||
| const siteTitle = `Devs DO` | ||
| const siteTitle = `DominicanWho.Codes`; | ||
|
|
||
| const { getByText } = render(<Header siteTitle={siteTitle} />); | ||
|
|
||
| const title = getByText(siteTitle); | ||
|
|
||
| expect(title).toBeInTheDocument(); | ||
| }) | ||
| }); | ||
|
|
||
| it("renders correctly", () => { | ||
| const siteTitle = `Devs DO` | ||
| const siteTitle = `DominicanWho.Codes`; | ||
| const tree = renderer | ||
| .create(<Header siteTitle={siteTitle} />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| }) | ||
| }) | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import * as React from "react"; | ||
| import { render } from "@testing-library/react"; | ||
| import renderer from "react-test-renderer"; | ||
| import Navbar from "../navbar"; | ||
|
|
||
| describe("Navbar", () => { | ||
| it("renders navbar open", () => { | ||
| const open = true; | ||
| const textInDocument = "About"; | ||
| const { getByText } = render(<Navbar open={open} />); | ||
|
|
||
| const menuOption = getByText(textInDocument); | ||
| expect(menuOption).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("render correctly", () => { | ||
| const open = false; | ||
|
|
||
| const tree = renderer.create(<Navbar open={open} />).toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
|
|
||
| }) | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.