Skip to content

Replace the 'Open in Histomics UI' menu item with a button #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eagw merged 4 commits into from
Jun 13, 2022
Merged

Replace the 'Open in Histomics UI' menu item with a button #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
399d42e
Replace 'Open in Histomics UI' menu item with separate button
eagw Jun 13, 2022
0b758ec
Fix spacing for new 'Open in HUI' button
eagw Jun 13, 2022
c5a8dd9
Change reference for button location from upload
eagw Jun 13, 2022
60937ae
Remove accidental extra 'Open in HUI' button
eagw Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions histomicsui/web_client/stylesheets/views/itemList.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@
margin-right 0.2em
text-align center
line-height 1em

.g-hui-open-item
margin-left 10px
13 changes: 5 additions & 8 deletions histomicsui/web_client/views/itemPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,11 @@ wrap(ItemView, 'render', function (render) {
'<li role="presentation"><a class="g-hui-quarantine-item" role="menuitem"><span>Q</span>Quarantine item</a></li>'
);
}
if (this.$el.find('.g-item-actions-menu').length && !this.$el.find('.g-hui-open-item[role="menuitem"]').length &&
this.model.attributes.largeImage) {
this.$el.find('.g-item-actions-menu').prepend(
`<li role="presentation">
<a class="g-hui-open-item" role="menuitem" href="${webrootPath}#?image=${this.model.id}" target="_blank">
<i class="icon-link-ext"></i>Open in ${brandName}
</a>
</li>`
if (!this.$el.find('.g-hui-open-item[role="button"]').length && this.model.attributes.largeImage) {
this.$el.find('.g-item-header .btn-group').before(
`<a class="g-hui-open-item btn btn-sm btn-primary" role="button" href="${webrootPath}#?image=${this.model.id}" target="_blank">
<i class="icon-link-ext"></i>Open in ${brandName}
</a>`
);
}
this.events['click .g-hui-quarantine-item'] = quarantine;
Expand Down