Conversation
Contributor
|
This is good. The only consideration is that for non-geometric annotations (images, superpixels, heatmaps), often there is only one so showing something like "image 1" seems less desirable than "image". My recommendation is for non-geometric annotations, don't add " 1" if there is only one element. |
Now, the first pixelmap, heatmap, etc. element won't include a number as part of its label when listed in the draw widget. Subsequent elements of the same type will have a number.
naglepuff
force-pushed
the
element-names
branch
from
170a346 to
a9508f0
Compare
Contributor
Author
|
In a9508f0 I've modified it so the first non-geometric element of each type in an annotation has no number in its label. |
manthey
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #195
This PR creates more descriptive element labels for annotations listed in the draw widget. In addition to the element type, for point, rectangle, ellipse, circle and polyline elements, the group name of the element and a number is added to the element label.
If an element is assigned a new group when edited, the label is updated to reflect the new group.
The number corresponding to each element is just a counter that starts at 1 and counts up for each element in the annotation. It is not a long-term ID for the element, and more of a way to more easily differentiate between two elements in the list. New elements added to the annotation (e.g. by being drawn on) are assigned a number as well. When the page is refreshed, the numbers are recalculated. This design might not be optimal and is intended to be a starting point.