feat(flags): add new flags to Embed and update Attachment flags #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Snipy7374
commented
Jan 31, 2025
Snipy7374
commented
Jan 31, 2025
Comment on lines
274
to
284
| if self._thumbnail and (thumbnail_flags := self._thumbnail.get("flags")): | ||
| self._thumbnail["flags"] = EmbedMediaFlags._from_value(thumbnail_flags) # type: ignore | ||
|
|
||
| self._video = data.get("video") | ||
| self._provider = data.get("provider") | ||
| self._author = data.get("author") | ||
|
|
||
| self._image = data.get("image") | ||
| if self._image and (image_flags := self._image.get("flags")): | ||
| self._image["flags"] = EmbedMediaFlags._from_value(image_flags) # type: ignore | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I don't like how this is done but I don't see much alternatives
Member
There was a problem hiding this comment.
Rather than save it here, we could make the flags when we access the image or thumbnail, no?
Member
There was a problem hiding this comment.
This also no longer seems to be respected in serialisation.
Collaborator
Author
There was a problem hiding this comment.
This also no longer seems to be respected in serialisation.
What do you mean? It's not consistent with the lib?
Snipy7374
added
t: enhancement
Enegg
reviewed
Jan 31, 2025
Snipy7374
requested review from
Enegg and
shiftinv
and removed request for
Enegg
Enegg
reviewed
Aug 22, 2025
Co-authored-by: Eneg <[email protected]> Signed-off-by: arielle <[email protected]>
onerandomusername
removed
the
s: waiting for api/docs
onerandomusername
approved these changes
Sep 29, 2025
Member
|
@Snipy7374 would you please resolve conflicts and rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
pdm lintpdm pyright