feature: recreate indexes by swapping them under a common alias#63
Draft
slri wants to merge 2 commits intoDivanteLtd:masterfrom
Draft
feature: recreate indexes by swapping them under a common alias#63slri wants to merge 2 commits intoDivanteLtd:masterfrom
slri wants to merge 2 commits intoDivanteLtd:masterfrom
Conversation
…der a common alias
slri
force-pushed
the
feature/index-swapping
branch
from
de58697 to
87a10a9
Compare
dkarlovi
suggested changes
May 20, 2021
Contributor
dkarlovi
left a comment
dkarlovi
left a comment
There was a problem hiding this comment.
Overall good work. some small tweaks.
| * @return array<ImporterFactory> | ||
| */ | ||
| public function create(?string $site = null, ?string $type = null, ?string $language = null, ?string $store = null, ?\DateTimeInterface $since = null): array | ||
| public function create(?string $site = null, ?string $type = null, ?string $language = null, ?string $store = null, ?\DateTimeInterface $since = null, ?string $runTimestamp = null): array |
Contributor
There was a problem hiding this comment.
We don't need this to be configurable, it will never be changed to anything else.
| $indexSettings = new IndexSettings( | ||
| $className, | ||
| $indexName, | ||
| $runTimestamp ? $indexName.'_'.$runTimestamp : $indexName, |
Contributor
There was a problem hiding this comment.
Better name, maybe $indexSuffix?
| ->addArgument('language', InputArgument::OPTIONAL, 'Language to index') | ||
| ->addArgument('store', InputArgument::OPTIONAL, 'Site store to index') | ||
| ->addOption('updated-since', 's', InputOption::VALUE_OPTIONAL, 'Fetch objects updated in the relative timeframe ("5minute", "2hour", "1day", "yesterday" etc)') | ||
| ->addOption('swap', null, InputOption::VALUE_OPTIONAL, 'Do a full reingest by swapping indices', false) |
Contributor
There was a problem hiding this comment.
Booleans use InputOption::VALUE_NONE, they're false by default.
| return $this->baseIndexService; | ||
| } | ||
|
|
||
| public function __call($method, $args) |
Contributor
There was a problem hiding this comment.
This is unfortunate, but I guess it's the only way to do it. Wish IndexService had an interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is currently a draft
Problem:
When working with data, some objects will be intentionally deleted. If we want a fresh instance of the index without stale/deleted data, we'd need to recreate it. When recreating it the only available way right now, we'd delete the index and then wait for it to be recreated again. This approach harms overall performance since the site is technically down or will have partial data until the indexing finishes.
Solution:
Use index name as an alias instead and create indices with a timestamp of the indexing time attached. While the new index is being created, the old index will still keep the website operational. Once the new index is ready, delete the old index. This ensures that even though we might have stale data for a little while longer, we at least will have it.