Skip to content

mapToDocument Method should be compatible with parent Class #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
welarrim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mapToDocument Method should be compatible with parent Class #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/CoreShop2VueStorefrontBundle/Bridge/DocumentMapper/DocumentConfigurableProductMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Cocur\Slugify\SlugifyInterface;
use CoreShop\Component\Core\Model\ProductInterface;
use CoreShop\Component\Core\Model\StoreInterface;
use CoreShop\Component\Core\Repository\ProductRepositoryInterface;
use CoreShop2VueStorefrontBundle\Bridge\DocumentMapperInterface;
use CoreShop2VueStorefrontBundle\Bridge\Helper\DocumentHelper;
Expand All @@ -14,6 +15,7 @@
use CoreShop2VueStorefrontBundle\Document\Product;
use CoreShop2VueStorefrontBundle\Document\ProductCategory;
use CoreShop2VueStorefrontBundle\Repository\AttributeRepository;
use ONGR\ElasticsearchBundle\Service\IndexService;
use Pimcore\Model\DataObject\AbstractObject;

class DocumentConfigurableProductMapper extends DocumentProductMapper implements DocumentMapperInterface
Expand Down Expand Up @@ -55,12 +57,16 @@ public function supports($objectOrClass): bool
}

/**
* @param ProductInterface $product
* @param IndexService $service
* @param object $product
* @param string $language
* @param StoreInterface $store
*
* @return Product
*/
public function mapToDocument($product, object $document, ?string $language = null): Product
public function mapToDocument(IndexService $service, object $product, ?string $language = null, ?StoreInterface $store = null): Product
{
$esProduct = parent::mapToDocument($product, $document, $language);
$esProduct = parent::mapToDocument($service, $product, $language, $store);
$esProduct->setTypeId(self::PRODUCT_TYPE_CONFIGURABLE);

$this->setConfigurable($product, $esProduct);
Expand Down