Handle update of products without categories#43
Open
roynilsson wants to merge 2 commits intoDivanteLtd:developfrom
Open
Handle update of products without categories#43roynilsson wants to merge 2 commits intoDivanteLtd:developfrom
roynilsson wants to merge 2 commits intoDivanteLtd:developfrom
Conversation
harihhs
reviewed
Oct 22, 2020
harihhs
left a comment
harihhs
left a comment
There was a problem hiding this comment.
This simple change makes product import clean even without a catalog.
Thanks @roynilsson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the product does not have any categories set in Pimcore then the value for category_ids will be null. The
countfunction does not allow null as a parameter and crashes the import. Adding a simple is_iterable to the if statement solves the problem and allows products without categories to be imported.