Skip to content
This repository was archived by the owner on Dec 30, 2019. It is now read-only.

[W.I.P.][Migration] Webpack 4 - detecting outstanding issues. #6

Merged
merged 1 commit into from
May 7, 2018

Conversation

DorianGrey
Copy link
Owner

@DorianGrey DorianGrey commented Mar 1, 2018

Just tested... and there still are tons of errors due to incompatible loader resp. plugin versions. But it seems I'm not the only one facing these ... Below are the errors I was able to figure out shortly, in addition to a couple of PRs containing (potential?) fixes.

Other problems detected:

  • Need to provide a polyfill for Array.prototype.includes to support IE11 during development (refactoring placed in Refactor/indexof to includes webpack/webpack#6298) - yeah, nobody likes this browser, but it's still a requirement in quite a lot of use-cases resp. projects, thus ...
  • Some styles of vue-carousel-3d somehow get lost. Neither the purge nor the optimize CSS plugin are responsible for this. Seems to have something to do with the way styles of lazy-loaded component are extracted and picked up. Might have something to do with https://github.com/vuejs/vue-loader. Done, at least mostly. Was a problem with a wrong configuration for CSS extraction. However, it now extracts CSS from chunks that should not have any (runtime and vendor). That's really weird...
  • Workbox v3 seems to attempt to import every available module, even though only two of them are in use. That's especially a problem with the google-analytics module, which may get blocked by clients, breaking the whole service worker and thus making it non-functional at all ...

Further changes:

@DorianGrey DorianGrey force-pushed the webpack-4 branch 3 times, most recently from eef652a to cfef466 Compare March 16, 2018 09:05
@DorianGrey DorianGrey force-pushed the webpack-4 branch 2 times, most recently from b667b4c to 9471701 Compare March 23, 2018 07:24
@DorianGrey DorianGrey force-pushed the webpack-4 branch 2 times, most recently from 32bf392 to 7b843e9 Compare April 3, 2018 06:26
@DorianGrey DorianGrey force-pushed the webpack-4 branch 3 times, most recently from df15b5f to b016aa9 Compare April 19, 2018 06:25
Includes a huge amount of additional updates as well.
@DorianGrey DorianGrey merged commit f1cd43d into master May 7, 2018
@DorianGrey
Copy link
Owner Author

This one was pre-merged, since further updates depend on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant