Skip to content

Fix featureset CI for wasmtime_runtime_layer #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

juntyr
Copy link
Collaborator

@juntyr juntyr commented Nov 23, 2024

Follow-up to #28 (good that we now have CI to catch my mistakes :) )

@juntyr
Copy link
Collaborator Author

juntyr commented Nov 23, 2024

Huh, now I'm a bit out of ideas. The wasm-pack command runs locally without issues. @DouglasDwyer Do you have any ideas?

@DouglasDwyer
Copy link
Owner

There seems to be an issue with wasm-bindgen-test and Rust >= 1.82.0: rustwasm/wasm-bindgen#4274 (comment)

For now, I have updated the ci.yaml on this branch to run the tests on Rust 1.81.0. If that seems like a good solution to you, then let me know and I'll merge. Otherwise, feel free to revert my change if you have a different idea.

@juntyr
Copy link
Collaborator Author

juntyr commented Nov 24, 2024

Thank you for identifying a fix - let’s merge this :)

@DouglasDwyer DouglasDwyer merged commit 5f049cd into DouglasDwyer:master Nov 24, 2024
5 checks passed
@juntyr juntyr deleted the ci branch November 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants