list/available: find Mac or Windows version based on the unity_shader package. Fixes #349

[lacostej]

More stable and finds both older and newer versions that are dependent on the DownloadAssistant

Pull Request Checklist

• My pull request has been rebased on master
• I ran bundle exec rspec to make sure that my PR didn't break any test
• I ran bundle exec rubocop to make sure that my PR is inline with our code style
• I have read the code of conduct

[niezbop]

Strong approval! It's super nice to have a unified way to fetch versions for both platform. I'm curious as to why the UnityDownloadAssistant wasn't matched (ie 2018.3.4 https://download.unity3d.com/download_unity/1d952368ca3a/UnityDownloadAssistant.dmg). The center hash? Anyhow, this is better

[niezbop]

Interesting results! It looks like a few earlier versions were already forgotten:

paulniezborala@Pauls-MBP Development $ git diff --no-index current.available newer.available
diff --git a/current.available b/newer.available
index acf1480..5972645 100644
--- a/current.available
+++ b/newer.available
@@ -2,11 +2,12 @@
 Loading Unity lts releases
 Found 23 lts releases.
 Loading Unity stable releases
-Found 109 stable releases.
+Found 124 stable releases.
 Loading Unity patch releases
 Found 191 patch releases.
 Loading Unity latest releases
 Found 8 latest releases.
+Unity version 2018.3.7f1 already fetched, replacing https://netstorage.unity3d.com/unity/9e14d22a41bb/ with https://download.unity3d.com/download_unity/9e14d22a41bb/
 Version 5.0.0f4: https://download.unity3d.com/download_unity/5b98b70ebeb9/
 Version 5.0.0p1: https://beta.unity3d.com/download/b38b89c951b3/
 Version 5.0.0p2: https://beta.unity3d.com/download/b8242d3df8b0/
@@ -200,7 +201,8 @@ Version 5.6.5p1: https://beta.unity3d.com/download/b5fcd78dd1ab/[m
 Version 5.6.5p2: https://beta.unity3d.com/download/02430129007d/
 Version 5.6.5p3: https://beta.unity3d.com/download/bb37b8531d94/
 Version 5.6.5p4: https://beta.unity3d.com/download/10861494ddb7/
-Version 5.6.6f2: http://beta.unity3d.com/download/6bac21139588/
+Version 5.6.6f2: https://download.unity3d.com/download_unity/6bac21139588/
+Version 5.6.7f1: https://download.unity3d.com/download_unity/e80cc3114ac1/
 Version 2017.1.0f3: https://download.unity3d.com/download_unity/472613c02cf7/
 Version 2017.1.0p1: https://beta.unity3d.com/download/2f459b492f3c/
 Version 2017.1.0p2: https://beta.unity3d.com/download/31954117ff6c/
@@ -314,7 +316,13 @@ Version 2018.2.18f1: https://download.unity3d.com/download_unity/455089
 Version 2018.2.19f1: https://download.unity3d.com/download_unity/06990f28ba00/
 Version 2018.2.20f1: https://download.unity3d.com/download_unity/cef3e6c0c622/
 Version 2018.2.21f1: https://download.unity3d.com/download_unity/a122f5dc316d/
+Version 2018.3.0f2: https://download.unity3d.com/download_unity/6e9a27477296/
+Version 2018.3.1f1: https://download.unity3d.com/download_unity/bb579dc42f1d/
+Version 2018.3.2f1: https://download.unity3d.com/download_unity/b3c100a4b73a/
 Version 2018.3.3f1: https://download.unity3d.com/download_unity/393bae82dbb8/
+Version 2018.3.4f1: https://download.unity3d.com/download_unity/1d952368ca3a/
+Version 2018.3.5f1: https://download.unity3d.com/download_unity/76b3e37670a4/
+Version 2018.3.6f1: https://download.unity3d.com/download_unity/a220877bc173/
 Version 2018.3.7f1: https://download.unity3d.com/download_unity/9e14d22a41bb/
 Version 2019.1.0b5: https://beta.unity3d.com/download/9899a5bd7e43/
 Version 2019.2.0a7: https://beta.unity3d.com/download/b5f63d908f8e/