u3d/install: convert Windows paths to ruby paths when treating U3D_EXTRA_PATHS #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I didn't test this :) |
lacostej
force-pushed
the
fix/windows_extra_install_path
branch
from
9678e29 to
6f4dbed
Compare
lacostej
force-pushed
the
fix/windows_extra_install_path
branch
from
6f4dbed to
3be4934
Compare
niezbop
reviewed
Nov 21, 2019
Member
There was a problem hiding this comment.
Not super found of that. I was thinking of tackling this as well. I would have tried the following:
File.expand_path(path)may actually work IIRC, I wanted to test this out. Plus it would be more Unix-friendly- Create a U3dCore::Helper method if expand_path doesn't work, such as the existing
U3dCore::Helper.windows_path
Member
Author
|
👍 I let you test&fix this then. |
lacostej
force-pushed
the
fix/windows_extra_install_path
branch
from
437c5d1 to
0fb0a8f
Compare
Member
Author
Member
|
@lacostej Cool! I was pretty sure |
Member
💯 |
lacostej
force-pushed
the
fix/windows_extra_install_path
branch
from
3c45367 to
c6318e7
Compare
lacostej
force-pushed
the
fix/windows_extra_install_path
branch
from
c6318e7 to
a3e8704
Compare
niezbop
requested changes
Nov 22, 2019
Member
niezbop
left a comment
niezbop
left a comment
There was a problem hiding this comment.
The implementation looks food to me, but I'd rather have a little cleanup of the specs.
niezbop
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
The documentation states that U3D_EXTRA_PATHS are windows style.
Fixes #383