Fixing error when installing Unity 2020 version in Linux #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoTorresSED
changed the title
|
I came across needing this fix for my utilization with 2020 as well, thanks & this works well! |
Member
|
Thanks @DiegoTorresSED Completely missed that PR. |
Member
|
Looks OK to me. |
niezbop
approved these changes
Apr 12, 2022
Member
niezbop
left a comment
niezbop
left a comment
There was a problem hiding this comment.
Looks fine to me as well! Thanks for doing that @DiegoTorresSED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
[DESCRIBE YOUR PULL REQUEST HERE]
This pull request solves the error when installing in Linux a Unity version 2020. It seems that untill Unity 2019, the unity_builtin_extra file has the string version coded at byte position 20. In 2020 the string version is coded from byte position 48. It has been coded a check for trying reading what it is expected in 2019 and if it is "\x00" set the seek position for 2020.