Support ruby3 and later on Windows (fixes #414) #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndler. Drops ruby 2.4
…p-rspec as it gives too many issues :)
lacostej
force-pushed
the
features/win32/ruby3
branch
from
3d1c932 to
c893ce6
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
1701f71 to
8903179
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
de557c3 to
2abff88
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
2abff88 to
78c5d5e
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
d27b9ea to
c8bf52f
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
c8bf52f to
5c3421c
Compare
lacostej
force-pushed
the
features/win32/ruby3
branch
from
c908e9e to
352b767
Compare
lacostej
changed the title
Member
Author
|
I wasn't able to fully implement the original implementation yet, but the hack will work in most cases for now. |
lacostej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
bundle exec rspecto make sure that my PR didn't break any testbundle exec rubocopto make sure that my PR is inline with our code stylePull Request Description
Solves portability of Windows specific/native code on ruby 2.5 and later.