Skip to content

fix: packaging and code hygiene fixes#25

Draft
toddr-bot wants to merge 1 commit intomainfrom
koan.toddr.bot/housekeeping
Draft

fix: packaging and code hygiene fixes#25
toddr-bot wants to merge 1 commit intomainfrom
koan.toddr.bot/housekeeping

Conversation

@toddr-bot
Copy link
Copy Markdown

@toddr-bot toddr-bot commented Apr 22, 2026

What

Three small, independent fixes consolidated into one PR to reduce review burden.

Why

Each fix is one line. Three separate PRs for three one-line changes creates unnecessary review overhead on a project with 13 open PRs.

How

  1. cpanfile: Replace Digest::MD5 with MIME::Base64. Digest::MD5 is a circular dependency (Digest::MD5 depends on Digest). MIME::Base64 is the actual runtime dependency used by Digest::base::base64_padded_digest.
  2. t/base.t: Use 3-arg open() instead of 2-arg. Prevents potential file name injection in test code.
  3. Makefile.PL: Fix META_MERGE repository URLs — Dual-Life/digestDual-Life/Digest to match the actual GitHub repo name.

Supersedes

Testing

make test passes.

🤖 Generated with Claude Code


Quality Report

Changes: 3 files changed, 5 insertions(+), 5 deletions(-)

Code scan: clean

Tests: passed (OK)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

Three small, independent fixes:
- cpanfile: replace Digest::MD5 (circular dep) with MIME::Base64 (actual dep)
- t/base.t: use 3-arg open for security best practice
- Makefile.PL: correct META_MERGE repository URLs casing (digest → Digest)

Supersedes #12, #13, and #17.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant