-
Notifications
You must be signed in to change notification settings - Fork 182
[WIP: needs install.bat] ci: add windows installer #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Windows does not support nusb::Device.control_out_blocking Claim the interface before writing as required on Windows.
- conditionally build diag_device.rs only for unix - use build time target for runtime metadata on unix
https://github.com/oopsbagel/rayhunter/actions/runs/14321594079
Someone with an Orbic and an active windows install (maybe even just a VM?) will have to test to make sure the serial binary actually does root the device. |
siiiiiick I will test this out! |
Serial script seems to work on windows at least as far as running, unforutnately running any command I get a driver error:
This should theoretically be fixed by installing a driver which could be done in the install.ps script so I will look into it. |
upon installing the driver the error changes to
|
I think it's failing to detach, not claim or use. |
Backtraces may be helpful, recompiling with .expect() instead of .context() |
Requires a generic WinUSB Driver install which can be accomplished by the tool downloaded from https://zadig.akeo.ie/ but works once that is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This branch builds the serial binary and rayhunter-check on Windows.
This branch modifies the serial binary, lib's RuntimeMetadata::new(), and conditionally builds lib/diag_device.rs in order to build those artifacts for Windows.