-
Notifications
You must be signed in to change notification settings - Fork 183
documentation: Attempt to clarify supported devices #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement reordering from untitaker's suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
| Device | Region | | ||
| ------ | ------ | | ||
| [Orbic RC400L](./orbic.md) | Americas | | ||
| [TP-Link M7350](./tplink-m7350.md) | Africa, Europe, Middle East | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed over the tables again without reading the text properly, and at first glance it seems like we're saying M7310 does work in the US, as opposed to the M7350.
Maybe this can be solved with a third col for "price range", or we let the user figure it out. After all if the TP-Link does miraculously end up being sold for 5 USD I think there's no reason not to get it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up changing the table heading to "Recommended region", with the idea being we don't want to make this page too information-dense. The individual device pages can get into specific bands, while this page is meant to quickly steer users to which device to look for in their location.
These devices have been extensively tested by the core developers and are widely used. We recommend running Rayhunter on one of these devices if you can. | ||
- [Orbic RC400L](./orbic.md) | ||
- [TP-Link M7350](./tplink-m7350.md) | ||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image doesn't work well in dark mode
Individual device pages can go into detail about specific bands and roaming. This page is primarily for steering users towards which device to buy, and we only want to recommend devices that are affordable in their region.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this image 14 kloc, lol
I know 😭 I think it's because of all the crinkly bits on the world map. |
I'd like to keep the dimensions on the picture for later refactoring without changing the flow of the page.