This repository was archived by the owner on Aug 2, 2022. It is now read-only.
base speculation staleness on time#4706
Merged
heifner merged 1 commit intoJul 17, 2018
Merged
Conversation
Previously, we based the stale speculation check on the `_production_enabled` flag which is set, at most, once per process. This lead to a situation where a node which fell behind would still speculate. This changes that check to be based on the age of the head block so, nodes which fall behind will stop speculating. NOTE, this only affects speculative modes, actual production should attempt to proceed despite the age of the head block. relates to EOSIO#4649
heifner
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we based the stale speculation check on the
_production_enabledflag which is set, at most, once per process. This lead to a situation where a node which fell behind would still speculate. This changes that check to be based on the age of the head block so, nodes which fall behind will stop speculating. NOTE, this only affects speculative modes, actual production should attempt to proceed despite the age of the head block.relates to #4649