Treat libinjection parser errors as matches in DetectSQLi/DetectXSS and add benign regression tests#23
Merged
Easton97-Jens merged 2 commits intov3/master-libinjection-v4.0-testfrom Mar 27, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38d93911ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0b29169
into
v3/master-libinjection-v4.0-test
141 of 172 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
libinjectionreturn codes and ensure parser errors are handled as fail-safe matches.libinjectionreports an error so rules withcapturestill receive context for diagnostics.Description
libinjection_error.hand switch toinjection_result_treturn values fromlibinjection_sqliandlibinjection_xssfor explicit handling ofTRUE,FALSE, andERRORoutcomes.LIBINJECTION_RESULT_ERRORas a match (fail-safe) and log a parser error message while storing the raw input into TX.0 whencaptureis enabled.test/test-cases/regression/operator-detectsqli.jsonandtest/test-cases/regression/operator-detectxss.jsonto assert no matches for safe inputs.Testing
operator-detectsqli.jsonandoperator-detectxss.jsonfiles; all tests completed successfully.@detectSQLiand@detectXSS.Codex Task